Bug 179850

Summary: Web Inspector: Update the Trash / Clear icon
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, commit-queue, ews-watchlist, inspector-bugzilla-changes, joepeck, jond, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[IMAGE] In Watch Expressions
none
[IMAGE] In Console
none
[IMAGE] In Network
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2017-11-17 16:34:21 PST
Update the Trash / Clear icon Resize it slightly to fit with other icons. Change the design a bit so it seems more like a clear.
Attachments
[IMAGE] In Watch Expressions (263.60 KB, image/png)
2017-11-17 16:34 PST, Joseph Pecoraro 		no flags
Details
[IMAGE] In Console (208.53 KB, image/png)
2017-11-17 16:35 PST, Joseph Pecoraro 		no flags
Details
[IMAGE] In Network (257.53 KB, image/png)
2017-11-17 16:35 PST, Joseph Pecoraro 		no flags
Details
[PATCH] Proposed Fix (6.13 KB, patch)
2017-11-17 16:36 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-11-17 16:34:55 PST
Created attachment 327268 [details] [IMAGE] In Watch Expressions
Joseph Pecoraro
Comment 2 2017-11-17 16:35:06 PST
Created attachment 327269 [details] [IMAGE] In Console
Joseph Pecoraro
Comment 3 2017-11-17 16:35:19 PST
Created attachment 327270 [details] [IMAGE] In Network
Joseph Pecoraro
Comment 4 2017-11-17 16:36:21 PST
Created attachment 327271 [details] [PATCH] Proposed Fix
Matt Baker
Comment 5 2017-11-17 17:10:34 PST
Why is it necessary to have top: 1px? If this adjustment will always be needed, would it make more sense to bake it into the SVG so that it looks good out of the box?
Joseph Pecoraro
Comment 6 2017-11-17 17:40:08 PST
(In reply to Matt Baker from comment #5) > Why is it necessary to have top: 1px? If this adjustment will always be > needed, would it make more sense to bake it into the SVG so that it looks > good out of the box? This is only in the detail sidebars where it is next to 13x13 icons. In the normal tabs there are no modifications.
Matt Baker
Comment 7 2017-11-18 13:39:19 PST
(In reply to Joseph Pecoraro from comment #6) > (In reply to Matt Baker from comment #5) > > Why is it necessary to have top: 1px? If this adjustment will always be > > needed, would it make more sense to bake it into the SVG so that it looks > > good out of the box? > > This is only in the detail sidebars where it is next to 13x13 icons. > > In the normal tabs there are no modifications. Makes sense!
Matt Baker
Comment 8 2017-11-18 13:39:31 PST
Comment on attachment 327271 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 9 2017-11-18 13:59:06 PST
Comment on attachment 327271 [details] [PATCH] Proposed Fix Clearing flags on attachment: 327271 Committed r225019: <https://trac.webkit.org/changeset/225019>
WebKit Commit Bot
Comment 10 2017-11-18 13:59:08 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2017-11-18 14:00:32 PST
<rdar://problem/35633559>
Note You need to log in before you can comment on or make changes to this bug.