Bug 179848

Summary: Use a strongly typed identifier for SWServer::Connection
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, benjamin, cmarcelo, commit-queue, dbates, ews-watchlist, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2017-11-17 16:08:10 PST
Use a strongly typed identifier for SWServer::Connection, for clarity.
Attachments
Patch (83.62 KB, patch)
2017-11-17 16:29 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (83.58 KB, patch)
2017-11-17 16:37 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (83.87 KB, patch)
2017-11-17 16:51 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-11-17 16:29:27 PST
Created attachment 327266 [details] Patch
Brady Eidson
Comment 2 2017-11-17 16:35:36 PST
Comment on attachment 327266 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327266&action=review r+ with a naming comment > Source/WTF/wtf/ObjectIdentifier.h:65 > + uint64_t toUnsignedInteger() const { return m_identifier; } toUInt64()
Chris Dumez
Comment 3 2017-11-17 16:37:55 PST
Created attachment 327272 [details] Patch
Chris Dumez
Comment 4 2017-11-17 16:51:10 PST
Created attachment 327277 [details] Patch
WebKit Commit Bot
Comment 5 2017-11-17 17:35:57 PST
The commit-queue encountered the following flaky tests while processing attachment 327277 [details]: The commit-queue is continuing to process your patch.
Chris Dumez
Comment 6 2017-11-17 18:27:19 PST
Comment on attachment 327277 [details] Patch Clearing flags on attachment: 327277 Committed r225008: <https://trac.webkit.org/changeset/225008>
Chris Dumez
Comment 7 2017-11-17 18:27:21 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-11-17 18:28:21 PST
<rdar://problem/35628606>
Note You need to log in before you can comment on or make changes to this bug.