Summary: | Use a strongly typed identifier for SWServer::Connection | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | beidson, benjamin, cmarcelo, commit-queue, dbates, ews-watchlist, ggaren, webkit-bug-importer, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Chris Dumez
2017-11-17 16:08:10 PST
Created attachment 327266 [details]
Patch
Comment on attachment 327266 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327266&action=review r+ with a naming comment > Source/WTF/wtf/ObjectIdentifier.h:65 > + uint64_t toUnsignedInteger() const { return m_identifier; } toUInt64() Created attachment 327272 [details]
Patch
Created attachment 327277 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 327277 [details]:
The commit-queue is continuing to process your patch.
Comment on attachment 327277 [details] Patch Clearing flags on attachment: 327277 Committed r225008: <https://trac.webkit.org/changeset/225008> All reviewed patches have been landed. Closing bug. |