Bug 179834

Summary: Do not run webkitpy tests on multiple EWSes
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, dbates, ews-watchlist, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
ap: review+
Updated patch none

Aakash Jain
Reported 2017-11-17 12:03:22 PST
We now have a separate webkitpy test EWS which run webkitpy-tests on every patch (as appropriate). Currently all the EWSes which run tests also run webkitpy tests, but ignore it's output. There is no point in running these tests and ignoring the output. We should remove this old code.
Attachments
Proposed patch (2.72 KB, patch)
2017-11-17 12:12 PST, Aakash Jain 		ap: review+
DetailsFormatted DiffDiff
Updated patch (2.68 KB, patch)
2017-11-27 16:55 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2017-11-17 12:12:20 PST
To clarify, we don't want to run these tests on multiple EWSes. EWSes use the parameter --non-interactive. We still want to run these tests when running manually, i.e. when --non-interactive option is not passed.
Aakash Jain
Comment 2 2017-11-17 12:12:38 PST
Created attachment 327210 [details] Proposed patch
Alexey Proskuryakov
Comment 3 2017-11-18 21:10:41 PST
Comment on attachment 327210 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=327210&action=review > Tools/Scripts/webkitpy/tool/steps/runtests.py:87 > + python_unittests_command = self._tool.deprecated_port().run_python_unittests_command() The FIXME above doesn’t seem accurate for webkitpy
Aakash Jain
Comment 4 2017-11-27 16:55:35 PST
Created attachment 327716 [details] Updated patch Patch for landing.
WebKit Commit Bot
Comment 5 2017-11-27 17:21:43 PST
Comment on attachment 327716 [details] Updated patch Clearing flags on attachment: 327716 Committed r225206: <https://trac.webkit.org/changeset/225206>
WebKit Commit Bot
Comment 6 2017-11-27 17:21:45 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-11-27 17:27:29 PST
<rdar://problem/35712592>
Note You need to log in before you can comment on or make changes to this bug.