Bug 179829

Summary:

Don't invert a matrix for every channel of every pixel of an FETurbulence filter

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, ews-watchlist, kondapallykalyan, rniwa, ryanhaddad, sabouhallawa, simon.fraser, webkit-bug-importer, zimmermann

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	dino: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews100 for mac-elcapitan	none
Archive of layout-test-results from ews114 for mac-elcapitan	none

Simon Fraser (smfr)

Reported 2017-11-17 10:46:38 PST

First of a few FETurbulence optimizations.

Attachments
Patch (3.35 KB, patch) 2017-11-17 10:49 PST, Simon Fraser (smfr)	dino: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (2.51 MB, application/zip) 2017-11-17 11:46 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews100 for mac-elcapitan (2.94 MB, application/zip) 2017-11-17 12:25 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-elcapitan (3.01 MB, application/zip) 2017-11-17 13:20 PST, EWS Watchlist	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2017-11-17 10:49:47 PST

Created attachment 327195 [details] Patch

EWS Watchlist

Comment 2 2017-11-17 11:46:47 PST

Comment on attachment 327195 [details] Patch Attachment 327195 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5277789 New failing tests: svg/filters/feTurbulence_bad_seeds.html

EWS Watchlist

Comment 3 2017-11-17 11:46:48 PST

Created attachment 327204 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 4 2017-11-17 12:25:03 PST

Comment on attachment 327195 [details] Patch Attachment 327195 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5278504 New failing tests: svg/filters/feTurbulence_bad_seeds.html

EWS Watchlist

Comment 5 2017-11-17 12:25:04 PST

Created attachment 327213 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 6 2017-11-17 13:20:05 PST

Comment on attachment 327195 [details] Patch Attachment 327195 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5279163 New failing tests: svg/filters/feTurbulence_bad_seeds.html

EWS Watchlist

Comment 7 2017-11-17 13:20:06 PST

Created attachment 327222 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Simon Fraser (smfr)

Comment 8 2017-11-17 15:08:23 PST

Test failure was because of an unwanted rounding of a FloatPoint to an IntPoint. Fixed before landing.

Simon Fraser (smfr)

Comment 9 2017-11-17 15:37:11 PST

https://trac.webkit.org/r224996

Radar WebKit Bug Importer

Comment 10 2017-11-17 15:39:00 PST

<rdar://problem/35625910>

Ryan Haddad

Comment 11 2017-11-17 16:58:47 PST

LayoutTest svg/W3C-SVG-1.1-SE/types-dom-04-b.svg is failing after this change: https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r224997%20(6220)/results.html

Note You need to log in before you can comment on or make changes to this bug.