Bug 179819

Summary:

Move destroyLeftoverChildren call to RenderObject::destroy

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, ews-watchlist, rniwa, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	zalan: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
patch	none
patch	none
patch	none

Antti Koivisto

Reported 2017-11-17 07:15:52 PST

For safety.

Attachments
patch (1.30 KB, patch) 2017-11-17 07:17 PST, Antti Koivisto	zalan: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (3.27 MB, application/zip) 2017-11-17 08:11 PST, EWS Watchlist	no flags	Details
patch (2.21 KB, patch) 2017-11-17 08:33 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (5.10 KB, patch) 2017-11-17 09:22 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (5.66 KB, patch) 2017-11-17 09:57 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2017-11-17 07:17:44 PST

Created attachment 327169 [details] patch

alan

Comment 2 2017-11-17 07:23:32 PST

Comment on attachment 327169 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=327169&action=review > Source/WebCore/ChangeLog:3 > + Add release assert that RenderLayer is out of tree before destruction ..is detached before destruction?

EWS Watchlist

Comment 3 2017-11-17 08:11:29 PST

Comment on attachment 327169 [details] patch Attachment 327169 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5274607 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 4 2017-11-17 08:11:30 PST

Created attachment 327173 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Antti Koivisto

Comment 5 2017-11-17 08:33:50 PST

Created attachment 327175 [details] patch

Antti Koivisto

Comment 6 2017-11-17 09:22:27 PST

Created attachment 327184 [details] patch

Antti Koivisto

Comment 7 2017-11-17 09:57:29 PST

Created attachment 327188 [details] patch

Radar WebKit Bug Importer

Comment 8 2017-11-17 10:40:30 PST

<rdar://problem/35618234>