Bug 179808

Summary: Navigation requests should use navigate fetch mode
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, ews-watchlist, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 180702    
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2017-11-16 17:40:51 PST
Navigation requests should use navigate fetch mode
Attachments
Patch (16.60 KB, patch)
2017-11-16 17:49 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (10.91 KB, patch)
2017-12-12 10:28 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-11-16 17:49:48 PST
Created attachment 327137 [details] Patch
youenn fablet
Comment 2 2017-12-12 10:28:30 PST
Created attachment 329124 [details] Patch
youenn fablet
Comment 3 2017-12-12 11:15:11 PST
Comment on attachment 329124 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329124&action=review > LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/request-end-to-end.https-expected.txt:2 > +FAIL Test FetchEvent.request passed to onfetch assert_equals: Constructing a Request with a Request whose mode is navigate and non-empty RequestInit must throw a TypeError. expected "TypeError" but got "" Test is making progress here. It is failing on the last check. This last check is actually wrong as per last fetch spec : constructor no longer throws that way, it silently change the mode to SameOrigin. We should update the WPT test upstream.
WebKit Commit Bot
Comment 4 2017-12-12 12:43:36 PST
Comment on attachment 329124 [details] Patch Clearing flags on attachment: 329124 Committed r225796: <https://trac.webkit.org/changeset/225796>
WebKit Commit Bot
Comment 5 2017-12-12 12:43:37 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-12-12 12:44:23 PST
<rdar://problem/36001655>
Note You need to log in before you can comment on or make changes to this bug.