| Summary: | Make sure service workers get terminated between tests | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, beidson, commit-queue, ggaren, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=179748 | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2017-11-16 09:10:14 PST
Created attachment 327093 [details]
Patch
Comment on attachment 327093 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327093&action=review > Source/WebCore/workers/service/server/SWServerJobQueue.cpp:52 > + clearRegistration(*registration); What is the intended side effect of clearRegistration? Is this what is called when a WebPage actually clears its service worker? If so, this patch would have the side effect of clearing *persistent* registrations too, and we don't want to do this between tests. Created attachment 327099 [details]
Patch
Comment on attachment 327099 [details] Patch Clearing flags on attachment: 327099 Committed r224955: <https://trac.webkit.org/changeset/224955> All reviewed patches have been landed. Closing bug. |