Bug 179774

Summary: Make sure service workers get terminated between tests
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=179748
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2017-11-16 09:10:14 PST
Make sure service workers get terminated between tests.
Attachments
Patch (3.37 KB, patch)
2017-11-16 12:07 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (6.90 KB, patch)
2017-11-16 13:18 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-11-16 12:07:06 PST
Created attachment 327093 [details] Patch
Brady Eidson
Comment 2 2017-11-16 12:32:49 PST
Comment on attachment 327093 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327093&action=review > Source/WebCore/workers/service/server/SWServerJobQueue.cpp:52 > + clearRegistration(*registration); What is the intended side effect of clearRegistration? Is this what is called when a WebPage actually clears its service worker? If so, this patch would have the side effect of clearing *persistent* registrations too, and we don't want to do this between tests.
Chris Dumez
Comment 3 2017-11-16 13:18:50 PST
Created attachment 327099 [details] Patch
WebKit Commit Bot
Comment 4 2017-11-16 18:32:16 PST
Comment on attachment 327099 [details] Patch Clearing flags on attachment: 327099 Committed r224955: <https://trac.webkit.org/changeset/224955>
WebKit Commit Bot
Comment 5 2017-11-16 18:32:17 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-11-16 18:33:19 PST
<rdar://problem/35605947>
Note You need to log in before you can comment on or make changes to this bug.