Bug 179752

Summary: [EME] Support generateRequest() in CDMFairPlayStreaming
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, eric.carlson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Jer Noble
Reported 2017-11-15 17:26:29 PST
[EME] SUpport generateRequest() in CDMFairPlayStreaming
Attachments
Patch (8.45 KB, patch)
2017-11-15 17:39 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (16.46 KB, patch)
2017-12-05 08:42 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (17.70 KB, patch)
2017-12-07 11:08 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2017-11-15 17:39:33 PST
Created attachment 327040 [details] Patch
Jer Noble
Comment 2 2017-12-05 08:42:12 PST
Created attachment 328453 [details] Patch
Eric Carlson
Comment 3 2017-12-06 16:31:37 PST
Comment on attachment 328453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328453&action=review > Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:143 > + if (result.first == "cbcs" || result.first == "cbc2" || result.first == "cbc1") Nit: these strings are used in several places, you should make them statics with MAKE_STATIC_STRING_IMPL(). > Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:163 > + InitDataRegistry::shared().registerInitDataType("sinf", { CDMPrivateFairPlayStreaming::sanitizeSinf, CDMPrivateFairPlayStreaming::extractKeyIDsSinf }); Nit: ASCIILiteral("sinf")
Jer Noble
Comment 4 2017-12-07 11:08:42 PST
Created attachment 328708 [details] Patch for landing
WebKit Commit Bot
Comment 5 2017-12-07 11:46:57 PST
Comment on attachment 328708 [details] Patch for landing Clearing flags on attachment: 328708 Committed r225637: <https://trac.webkit.org/changeset/225637>
WebKit Commit Bot
Comment 6 2017-12-07 11:46:59 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-12-07 11:47:18 PST
<rdar://problem/35914966>
Note You need to log in before you can comment on or make changes to this bug.