Bug 179710

Summary:

Clean up URL.h

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, darin, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	beidson: review+

Description Alex Christensen 2017-11-14 16:51:25 PST

Clean up URL.h

Comment 1 Alex Christensen 2017-11-14 16:52:49 PST

Created attachment 326947 [details]
Patch

Comment 2 Alex Christensen 2017-11-17 13:38:31 PST

http://trac.webkit.org/r224984

Comment 3 Radar WebKit Bug Importer 2017-11-17 13:39:37 PST

<rdar://problem/35622767>

Comment 4 Darin Adler 2017-11-20 22:09:29 PST

Comment on attachment 326947 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326947&action=review

> Source/WebCore/platform/URL.h:459
> +// URLHash is the default hash for String

I think this should say URLHash is the default hash for *URL*, not String.

> Source/WebCore/platform/URL.h:460
> +template<typename T> struct DefaultHash;

No need for "T" here, just <typename>.

> Source/WebCore/platform/URL.h:462
> +    typedef WebCore::URLHash Hash;

Should use "using" instead of typedef if touching this.