Bug 179709

Summary: [Service Workers] Implement Client API
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ggaren, ryanhaddad, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2017-11-14 16:44:38 PST
Implement Client API: - https://w3c.github.io/ServiceWorker/#client-interface
Attachments
Patch (55.32 KB, patch)
2017-11-14 19:34 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (59.96 KB, patch)
2017-11-15 09:26 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-11-14 19:34:18 PST
Created attachment 326961 [details] Patch
Alex Christensen
Comment 2 2017-11-14 23:39:22 PST
Comment on attachment 326961 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326961&action=review > Source/WebKit/Shared/WebCoreArgumentCoders.h:809 > +template <> struct EnumTraits<WebCore::ServiceWorkerClientType> { Could we just put these in WebCore?
Chris Dumez
Comment 3 2017-11-15 09:26:38 PST
Created attachment 326990 [details] Patch
WebKit Commit Bot
Comment 4 2017-11-15 10:00:29 PST
Comment on attachment 326990 [details] Patch Clearing flags on attachment: 326990 Committed r224880: <https://trac.webkit.org/changeset/224880>
WebKit Commit Bot
Comment 5 2017-11-15 10:00:31 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-11-15 10:04:41 PST
<rdar://problem/35562839>
Ryan Haddad
Comment 7 2017-11-15 11:31:08 PST
The LayoutTests added with this change are timing out on the bots: https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r224880%20(1174)/results.html
Chris Dumez
Comment 8 2017-11-15 11:51:02 PST
(In reply to Ryan Haddad from comment #7) > The LayoutTests added with this change are timing out on the bots: > > https://build.webkit.org/results/ > Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r224880%20(1174)/results.html It conflicted with Youenn's patch that landed right before mine. Should be fixed in <https://trac.webkit.org/changeset/224892>.
Note You need to log in before you can comment on or make changes to this bug.