| Summary: | [Service Workers] Implement Client API | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, beidson, commit-queue, ggaren, ryanhaddad, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2017-11-14 16:44:38 PST
Created attachment 326961 [details]
Patch
Comment on attachment 326961 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326961&action=review > Source/WebKit/Shared/WebCoreArgumentCoders.h:809 > +template <> struct EnumTraits<WebCore::ServiceWorkerClientType> { Could we just put these in WebCore? Created attachment 326990 [details]
Patch
Comment on attachment 326990 [details] Patch Clearing flags on attachment: 326990 Committed r224880: <https://trac.webkit.org/changeset/224880> All reviewed patches have been landed. Closing bug. The LayoutTests added with this change are timing out on the bots: https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r224880%20(1174)/results.html (In reply to Ryan Haddad from comment #7) > The LayoutTests added with this change are timing out on the bots: > > https://build.webkit.org/results/ > Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r224880%20(1174)/results.html It conflicted with Youenn's patch that landed right before mine. Should be fixed in <https://trac.webkit.org/changeset/224892>. |