Bug 179704

Summary: REGRESSION(r224787): [Linux] Introduced 144 GTK/WPE JS test failures
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: JavaScriptCoreAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, clopez, commit-queue, keith_miller, mcatanzaro, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: PC   
OS: Linux   
See Also: https://bugs.webkit.org/show_bug.cgi?id=179451
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2017-11-14 16:21:54 PST
r224787 "Async iteration should only fetch the next method once and add feature flag" introduced 144 JS test failures for GTK and WPE. Keith, maybe the tests depend on the ASYNC_ITERATION feature? After that commit, it's now disabled for CMake builds and enabled for XCode builds. Note: if you want to enable it for CMake builds, it just needs added to Source/cmake/WebKitFeatures.cmake. (It probably does not make sense to have any build flags not listed there, anyway.)
Attachments
Patch (1.56 KB, patch)
2017-11-15 10:07 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2017-11-15 10:07:46 PST
Created attachment 326994 [details] Patch
Yusuke Suzuki
Comment 2 2017-11-15 10:08:27 PST
Comment on attachment 326994 [details] Patch r=me
WebKit Commit Bot
Comment 3 2017-11-15 10:31:07 PST
Comment on attachment 326994 [details] Patch Clearing flags on attachment: 326994 Committed r224884: <https://trac.webkit.org/changeset/224884>
WebKit Commit Bot
Comment 4 2017-11-15 10:31:09 PST
All reviewed patches have been landed. Closing bug.
Michael Catanzaro
Comment 5 2017-11-15 10:54:13 PST
Could you alphabetize it please? :)
Keith Miller
Comment 6 2017-11-15 11:17:16 PST
(In reply to Michael Catanzaro from comment #5) > Could you alphabetize it please? :) Oh, I missed that they were alphabetized... I'll make another patch.
Keith Miller
Comment 7 2017-11-15 11:22:59 PST
Sorted in: https://trac.webkit.org/changeset/224888
Radar WebKit Bug Importer
Comment 8 2017-11-15 12:06:56 PST
<rdar://problem/35566964>
Note You need to log in before you can comment on or make changes to this bug.