Bug 179696

Summary: [Cocoa] Clean up names of conversion methods after renaming InspectorValue to JSON::Value
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: NEW    
Severity: Normal CC: bburg, buildbot, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Rebased Patch none

Blaze Burg
Reported 2017-11-14 15:03:45 PST
"This space is intentionally left blank."
Attachments
Patch (64.48 KB, patch)
2017-11-14 16:46 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Rebased Patch (64.86 KB, patch)
2017-11-28 15:05 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-11-14 15:53:39 PST
<rdar://problem/35544951>
Blaze Burg
Comment 2 2017-11-14 16:46:27 PST
Created attachment 326945 [details] Patch
Build Bot
Comment 3 2017-11-14 16:49:50 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Blaze Burg
Comment 4 2017-11-28 15:05:39 PST
Created attachment 327797 [details] Rebased Patch
Timothy Hatcher
Comment 5 2017-11-28 15:14:31 PST
Comment on attachment 327797 [details] Rebased Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327797&action=review Looks fine other than one comment. > Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:115 > - lines.append('- (instancetype)initWithJSONObject:(RWIProtocolJSONObject *)jsonObject') > + lines.append('- (instancetype)initWithProtocolObject:(RWIProtocolJSONObject *)object') > lines.append('{') > - lines.append(' if (!(self = [super initWithInspectorObject:[jsonObject toInspectorObject].get()]))') > + lines.append(' if (!(self = [super initWithJSONObject:[object toJSONObject].get()]))') This seems odd. Why change [self initWithJSONObject:] to initWithProtocolObject: when super is changing to initWithJSONObject:? Maybe this method should be initWithProtocolJSONObject:?
Blaze Burg
Comment 6 2017-11-28 15:19:41 PST
(In reply to Timothy Hatcher from comment #5) > Comment on attachment 327797 [details] > Rebased Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=327797&action=review > > Looks fine other than one comment. > > > Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:115 > > - lines.append('- (instancetype)initWithJSONObject:(RWIProtocolJSONObject *)jsonObject') > > + lines.append('- (instancetype)initWithProtocolObject:(RWIProtocolJSONObject *)object') > > lines.append('{') > > - lines.append(' if (!(self = [super initWithInspectorObject:[jsonObject toInspectorObject].get()]))') > > + lines.append(' if (!(self = [super initWithJSONObject:[object toJSONObject].get()]))') > > This seems odd. Why change [self initWithJSONObject:] to > initWithProtocolObject: when super is changing to initWithJSONObject:? > > Maybe this method should be initWithProtocolJSONObject:? I thought it was more sensible to let super be able to use initWithJSONObject rather than keep it in the subclass. Among the two names, I chose the shorter one.
Blaze Burg
Comment 7 2017-11-28 15:35:35 PST
Comment on attachment 327797 [details] Rebased Patch <https://trac.webkit.org/r225243>
Note You need to log in before you can comment on or make changes to this bug.