Bug 179692

Summary: Add feature define for alternative presentation button element
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bfulgham
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 179785    
Attachments:
Description Flags
Patch aestes: review+

Daniel Bates
Reported 2017-11-14 13:57:01 PST
Add feature define for alternative presentation button element.
Attachments
Patch (55.06 KB, patch)
2017-11-14 14:06 PST, Daniel Bates 		aestes: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2017-11-14 14:06:52 PST
Created attachment 326924 [details] Patch
Daniel Bates
Comment 2 2017-11-14 14:38:30 PST
Part of <rdar://problem/34917108>
Andy Estes
Comment 3 2017-11-16 10:31:21 PST
Comment on attachment 326924 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326924&action=review > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:252 > +ENABLE_ALTERNATIVE_PRESENTATION_BUTTON_ELEMENT = ENABLE_ALTERNATIVE_PRESENTATION_BUTTON_ELEMENT; I know that FeatureDefines are currently not sorted properly, but it would be nice to not make it worse. Can you put this between ENABLE_ACCELERATED_OVERFLOW_SCROLLING and ENABLE_APPLE_PAY?
Daniel Bates
Comment 4 2017-11-16 14:24:14 PST
(In reply to Andy Estes from comment #3) > Comment on attachment 326924 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326924&action=review > > > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:252 > > +ENABLE_ALTERNATIVE_PRESENTATION_BUTTON_ELEMENT = ENABLE_ALTERNATIVE_PRESENTATION_BUTTON_ELEMENT; > > I know that FeatureDefines are currently not sorted properly, but it would > be nice to not make it worse. Can you put this between > ENABLE_ACCELERATED_OVERFLOW_SCROLLING and ENABLE_APPLE_PAY? Will fix before landing.
Daniel Bates
Comment 5 2017-11-16 14:24:19 PST
Part of <rdar://problem/34917108>.
Daniel Bates
Comment 6 2017-11-16 17:17:34 PST
Committed r224950: <https://trac.webkit.org/changeset/224950>
Note You need to log in before you can comment on or make changes to this bug.