| Summary: | Add feature define for alternative presentation button element | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
| Component: | WebCore Misc. | Assignee: | Daniel Bates <dbates> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aestes, bfulgham | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Local Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 179785 | ||||||
| Attachments: |
|
||||||
|
Description
Daniel Bates
2017-11-14 13:57:01 PST
Created attachment 326924 [details]
Patch
Part of <rdar://problem/34917108> Comment on attachment 326924 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326924&action=review > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:252 > +ENABLE_ALTERNATIVE_PRESENTATION_BUTTON_ELEMENT = ENABLE_ALTERNATIVE_PRESENTATION_BUTTON_ELEMENT; I know that FeatureDefines are currently not sorted properly, but it would be nice to not make it worse. Can you put this between ENABLE_ACCELERATED_OVERFLOW_SCROLLING and ENABLE_APPLE_PAY? (In reply to Andy Estes from comment #3) > Comment on attachment 326924 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326924&action=review > > > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:252 > > +ENABLE_ALTERNATIVE_PRESENTATION_BUTTON_ELEMENT = ENABLE_ALTERNATIVE_PRESENTATION_BUTTON_ELEMENT; > > I know that FeatureDefines are currently not sorted properly, but it would > be nice to not make it worse. Can you put this between > ENABLE_ACCELERATED_OVERFLOW_SCROLLING and ENABLE_APPLE_PAY? Will fix before landing. Part of <rdar://problem/34917108>. Committed r224950: <https://trac.webkit.org/changeset/224950> |