Bug 179671

Summary: Stub implementations of OffscreenCanvas getContext and transferToImageBitmap
Product: WebKit Reporter: Dean Jackson <dino>
Component: CanvasAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, dino, esprehn+autocc, graouts, gyuyoung.kim, kondapallykalyan, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch graouts: review+

Dean Jackson
Reported 2017-11-14 09:54:53 PST
Stub implementations of OffscreenCanvas getContext and transferToImageBitmap
Attachments
Patch (8.99 KB, patch)
2017-11-14 09:59 PST, Dean Jackson 		graouts: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-11-14 09:55:10 PST
<rdar://problem/35534018>
Dean Jackson
Comment 2 2017-11-14 09:59:27 PST
Created attachment 326887 [details] Patch
Antoine Quint
Comment 3 2017-11-14 10:24:02 PST
Comment on attachment 326887 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326887&action=review > Source/WebCore/html/OffscreenCanvas.cpp:71 > + return { nullptr }; Shouldn't it be { }? > Source/WebCore/html/OffscreenCanvas.h:71 > + // FIXME: Should be optional<OffscreenRenderingContext> from above. Is there a bug for this? Shouldn't we discard OffscreenRenderingContext until it's ready to use?
Dean Jackson
Comment 4 2017-11-14 13:11:47 PST
Committed r224836: <https://trac.webkit.org/changeset/224836>
Ryan Haddad
Comment 5 2017-11-14 14:16:06 PST
(In reply to Dean Jackson from comment #4) > Committed r224836: <https://trac.webkit.org/changeset/224836> This change broke the Windows build: https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/6034
Note You need to log in before you can comment on or make changes to this bug.