| Summary: | Stub implementations of OffscreenCanvas getContext and transferToImageBitmap | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
| Component: | Canvas | Assignee: | Dean Jackson <dino> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | buildbot, cdumez, dino, esprehn+autocc, graouts, gyuyoung.kim, kondapallykalyan, ryanhaddad, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Dean Jackson
2017-11-14 09:54:53 PST
Created attachment 326887 [details]
Patch
Comment on attachment 326887 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326887&action=review > Source/WebCore/html/OffscreenCanvas.cpp:71 > + return { nullptr }; Shouldn't it be { }? > Source/WebCore/html/OffscreenCanvas.h:71 > + // FIXME: Should be optional<OffscreenRenderingContext> from above. Is there a bug for this? Shouldn't we discard OffscreenRenderingContext until it's ready to use? Committed r224836: <https://trac.webkit.org/changeset/224836> (In reply to Dean Jackson from comment #4) > Committed r224836: <https://trac.webkit.org/changeset/224836> This change broke the Windows build: https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/6034 |