Bug 179670

Summary: HaveInternalSDK includes should be "#include?"
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, dino, graouts, kondapallykalyan, mark.lam, mitz, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Keith Miller 2017-11-14 09:47:00 PST 
HaveInternalSDK includes should be "#include?"
Comment 1 Keith Miller 2017-11-14 09:54:54 PST 
Created attachment 326886 [details]
Patch
Comment 2 Build Bot 2017-11-14 09:57:04 PST 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 mitz 2017-11-14 10:26:52 PST 
Comment on attachment 326886 [details]
Patch

This syntax isn’t supported by all Xcode version used to build WebKit.
Comment 4 Keith Miller 2017-11-14 10:30:11 PST 
Indeed, it looks like this won't work with Xcode 7. Closing.
Comment 5 Keith Miller 2018-01-19 09:30:37 PST 
Looks like we dropped support for Xcode 7 recently. Reopening this for review.
Comment 6 Keith Miller 2018-01-19 09:31:27 PST 
rdar://problem/35298458
Comment 7 mitz 2018-01-19 09:35:30 PST 
Comment on attachment 326886 [details]
Patch

r=me on the .xcconfig changes, but the bmalloc project change seems unrelated
Comment 8 Keith Miller 2018-01-19 09:36:53 PST 
(In reply to mitz from comment #7)
> Comment on attachment 326886 [details]
> Patch
> 
> r=me on the .xcconfig changes, but the bmalloc project change seems unrelated

Oh, weird. I think that's an automatic sorting this that webkit-patch does now... I'll revert it.
Comment 9 Keith Miller 2018-01-19 09:39:48 PST 
Created attachment 331744 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2018-01-19 10:33:25 PST 
The commit-queue encountered the following flaky tests while processing attachment 331744 [details]:

imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-v-framesize.html bug 181565 (authors: cdumez@apple.com and jer.noble@apple.com)
The commit-queue is continuing to process your patch.
Comment 11 WebKit Commit Bot 2018-01-19 10:33:57 PST 
Comment on attachment 331744 [details]
Patch for landing

Clearing flags on attachment: 331744

Committed r227215: <https://trac.webkit.org/changeset/227215>
Comment 12 WebKit Commit Bot 2018-01-19 10:33:59 PST 
All reviewed patches have been landed.  Closing bug.
Comment 13 mitz 2018-01-27 09:51:13 PST 
(In reply to WebKit Commit Bot from comment #11)
> Comment on attachment 331744 [details]
> Patch for landing
> 
> Clearing flags on attachment: 331744
> 
> Committed r227215: <https://trac.webkit.org/changeset/227215>

More in <https://trac.webkit.org/r227715>.