Summary: | Send ServiceWorkerData structs to the WebProcesses instead of ServiceWorkerIdentifiers | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | beidson, commit-queue, ggaren, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Chris Dumez
2017-11-13 19:06:43 PST
Created attachment 326840 [details]
Patch
Created attachment 326844 [details]
Patch
Comment on attachment 326844 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326844&action=review > Source/WebCore/workers/service/ServiceWorkerData.cpp:40 > + return { > + identifier, > + scriptURL.isolatedCopy(), > + state, > + type > + }; We don't normally multi-line something like this. Comment on attachment 326844 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326844&action=review >> Source/WebCore/workers/service/ServiceWorkerData.cpp:40 >> + }; > > We don't normally multi-line something like this. I followed your pattern in ServiceWorkerRegistrationData :P (In reply to Chris Dumez from comment #4) > Comment on attachment 326844 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326844&action=review > > >> Source/WebCore/workers/service/ServiceWorkerData.cpp:40 > >> + }; > > > > We don't normally multi-line something like this. > > I followed your pattern in ServiceWorkerRegistrationData :P I think I multilined that because it was so many more thingies. But probably shouldn't have. :) Comment on attachment 326844 [details] Patch Clearing flags on attachment: 326844 Committed r224804: <https://trac.webkit.org/changeset/224804> All reviewed patches have been landed. Closing bug. |