Bug 179649

Summary: Send ServiceWorkerData structs to the WebProcesses instead of ServiceWorkerIdentifiers
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2017-11-13 19:06:43 PST
Send ServiceWorkerData structs to the WebProcesses instead of ServiceWorkerIdentifiers so that the WebProcesses can correctly construct ServiceWorker objects, with the right attributes / state.
Comment 1 Chris Dumez 2017-11-13 19:45:16 PST
Created attachment 326840 [details]
Patch
Comment 2 Chris Dumez 2017-11-13 20:24:51 PST
Created attachment 326844 [details]
Patch
Comment 3 Brady Eidson 2017-11-13 22:02:08 PST
Comment on attachment 326844 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326844&action=review

> Source/WebCore/workers/service/ServiceWorkerData.cpp:40
> +    return {
> +        identifier,
> +        scriptURL.isolatedCopy(),
> +        state,
> +        type
> +    };

We don't normally multi-line something like this.
Comment 4 Chris Dumez 2017-11-13 22:04:42 PST
Comment on attachment 326844 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326844&action=review

>> Source/WebCore/workers/service/ServiceWorkerData.cpp:40
>> +    };
> 
> We don't normally multi-line something like this.

I followed your pattern in ServiceWorkerRegistrationData :P
Comment 5 Brady Eidson 2017-11-13 22:12:34 PST
(In reply to Chris Dumez from comment #4)
> Comment on attachment 326844 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=326844&action=review
> 
> >> Source/WebCore/workers/service/ServiceWorkerData.cpp:40
> >> +    };
> > 
> > We don't normally multi-line something like this.
> 
> I followed your pattern in ServiceWorkerRegistrationData :P

I think I multilined that because it was so many more thingies.

But probably shouldn't have. :)
Comment 6 WebKit Commit Bot 2017-11-13 22:21:47 PST
Comment on attachment 326844 [details]
Patch

Clearing flags on attachment: 326844

Committed r224804: <https://trac.webkit.org/changeset/224804>
Comment 7 WebKit Commit Bot 2017-11-13 22:21:49 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-11-15 09:32:34 PST
<rdar://problem/35561904>