Bug 179630

Summary: [GTK] Require woff2 1.0.2 and drop direct brotli dependency
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, fred.wang, mcatanzaro, tpopela
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
See Also: https://bugs.webkit.org/show_bug.cgi?id=178158
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2017-11-13 13:23:03 PST
The initial releases of the woff2 library have a bug with the pkg-config file: they do not directly pull in brotli. We have worked around this thus far by requiring it manually, but this should not be needed. Tom fixed it with https://github.com/google/woff2/commit/aff949b84713590907b259ecb49f630a19df55c0. A new version is now available with this fix, which we should use.
Attachments
Patch (4.72 KB, patch)
2017-11-13 13:25 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2017-11-13 13:25:55 PST
Created attachment 326791 [details] Patch
WebKit Commit Bot
Comment 2 2017-11-13 16:42:23 PST
Comment on attachment 326791 [details] Patch Clearing flags on attachment: 326791 Committed r224793: <https://trac.webkit.org/changeset/224793>
WebKit Commit Bot
Comment 3 2017-11-13 16:42:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.