Bug 179616

Summary:

REGRESSION(r224658): check-webkit-style cannot construct valid iOS version without an iOS SDK

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, buildbot, commit-queue, dbates, ddkilzer, glenn, lforschler, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar, Regression

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=179534

Attachments:

Description	Flags
Patch	none

Jonathan Bedard

Reported 2017-11-13 10:16:13 PST

After <https://trac.webkit.org/changeset/224658>, when running check-webkit-style on a Mac without an iOS SDK, an exception is thrown. This is quite related to <https://bugs.webkit.org/show_bug.cgi?id=179534>, but the fix for this problem is much smaller and a subset of the fixed for the larger issue.

Attachments
Patch (1.84 KB, patch) 2017-11-13 10:22 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-11-13 10:16:35 PST

<rdar://problem/35507018>

Jonathan Bedard

Comment 2 2017-11-13 10:22:22 PST

Created attachment 326769 [details] Patch

Simon Fraser (smfr)

Comment 3 2017-11-13 10:33:28 PST

Comment on attachment 326769 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326769&action=review > Tools/ChangeLog:10 > + Instead of throwing an exception when we ask for an unavailable SDK on Mac, > + we should return None. But the problem is related to iOS SDKs, not mac.

Jonathan Bedard

Comment 4 2017-11-13 11:00:25 PST

Comment on attachment 326769 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326769&action=review >> Tools/ChangeLog:10 >> + we should return None. > > But the problem is related to iOS SDKs, not mac. It only happens on Mac when we ask for an SDK (which could be iOS, watchOS or tvOS, in our case, it's iOS that's causing the problem) which is unavailable. This change has implications beyond just the iOS SDK, although at the moment, that is the only SDK that uses this codepath.

David Kilzer (:ddkilzer)

Comment 5 2017-11-13 11:17:40 PST

Comment on attachment 326769 [details] Patch r=me Please check the Win EWS (it's orange) before landing.

Jonathan Bedard

Comment 6 2017-11-13 11:36:32 PST

(In reply to David Kilzer (:ddkilzer) from comment #5) > Comment on attachment 326769 [details] > Patch > > r=me > > Please check the Win EWS (it's orange) before landing. It was test failures for mac and a borked SVN for Windows, everything is green now.

WebKit Commit Bot

Comment 7 2017-11-13 11:55:21 PST

Comment on attachment 326769 [details] Patch Clearing flags on attachment: 326769 Committed r224765: <https://trac.webkit.org/changeset/224765>

WebKit Commit Bot

Comment 8 2017-11-13 11:55:22 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.