Bug 179616

Summary: REGRESSION(r224658): check-webkit-style cannot construct valid iOS version without an iOS SDK
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, buildbot, commit-queue, dbates, ddkilzer, glenn, lforschler, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar, Regression
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=179534
Attachments:
Description Flags
Patch none

Description Jonathan Bedard 2017-11-13 10:16:13 PST 
After <https://trac.webkit.org/changeset/224658>, when running check-webkit-style on a Mac without an iOS SDK, an exception is thrown.

This is quite related to <https://bugs.webkit.org/show_bug.cgi?id=179534>, but the fix for this problem is much smaller and a subset of the fixed for the larger issue.
Comment 1 Radar WebKit Bug Importer 2017-11-13 10:16:35 PST 
<rdar://problem/35507018>
Comment 2 Jonathan Bedard 2017-11-13 10:22:22 PST 
Created attachment 326769 [details]
Patch
Comment 3 Simon Fraser (smfr) 2017-11-13 10:33:28 PST 
Comment on attachment 326769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326769&action=review

> Tools/ChangeLog:10
> +        Instead of throwing an exception when we ask for an unavailable SDK on Mac,
> +        we should return None.

But the problem is related to iOS SDKs, not mac.
Comment 4 Jonathan Bedard 2017-11-13 11:00:25 PST 
Comment on attachment 326769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326769&action=review

>> Tools/ChangeLog:10
>> +        we should return None.
> 
> But the problem is related to iOS SDKs, not mac.

It only happens on Mac when we ask for an SDK (which could be iOS, watchOS or tvOS, in our case, it's iOS that's causing the problem) which is unavailable.

This change has implications beyond just the iOS SDK, although at the moment, that is the only SDK that uses this codepath.
Comment 5 David Kilzer (:ddkilzer) 2017-11-13 11:17:40 PST 
Comment on attachment 326769 [details]
Patch

r=me

Please check the Win EWS (it's orange) before landing.
Comment 6 Jonathan Bedard 2017-11-13 11:36:32 PST 
(In reply to David Kilzer (:ddkilzer) from comment #5)
> Comment on attachment 326769 [details]
> Patch
> 
> r=me
> 
> Please check the Win EWS (it's orange) before landing.

It was test failures for mac and a borked SVN for Windows, everything is green now.
Comment 7 WebKit Commit Bot 2017-11-13 11:55:21 PST 
Comment on attachment 326769 [details]
Patch

Clearing flags on attachment: 326769

Committed r224765: <https://trac.webkit.org/changeset/224765>
Comment 8 WebKit Commit Bot 2017-11-13 11:55:22 PST 
All reviewed patches have been landed.  Closing bug.