| Summary: | Some service worker tests are flaky due to console log messages | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, beidson, cdumez, commit-queue, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2017-11-12 22:14:39 PST
Created attachment 326744 [details]
Patch
Comment on attachment 326744 [details]
Patch
Then can we drop the Pass Failure?
(In reply to Chris Dumez from comment #2) > Comment on attachment 326744 [details] > Patch > > Then can we drop the Pass Failure? That is the plan once the tests show to be stable on bots. I think we should unskip them in this patch since we believe this addresses the flakiness. We can always skip them again if they turn out to be flaky still. Comment on attachment 326744 [details]
Patch
I agree. Let's just mark them as passing.
fetch-canvas-tainting.https.html and fetch-canvas-tainting-cache.https.html are consistently returning a FAIL result. But the reason for failure is sometimes changing, I will keep it as flaky in expectations. The other test seems more stable, I will update its expectation. Created attachment 326989 [details]
Patch for landing
Comment on attachment 326989 [details] Patch for landing Clearing flags on attachment: 326989 Committed r224891: <https://trac.webkit.org/changeset/224891> All reviewed patches have been landed. Closing bug. > The other test seems more stable, I will update its expectation. As per https://bugs.webkit.org/show_bug.cgi?id=179771, it is also flaky, I'll update it s expectation back to flaky... |