Bug 179584

Summary: Web Inspector: Add CheckboxNavigationItem
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Shown in rendering frames view toolbar
none
Patch none

Matt Baker
Reported 2017-11-11 15:14:11 PST
This will be useful for creating local setting checkboxes in toolbars.
Attachments
[Image] Shown in rendering frames view toolbar (94.30 KB, image/png)
2017-11-11 15:18 PST, Matt Baker 		no flags
Details
Patch (10.98 KB, patch)
2017-11-11 15:25 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-11-11 15:15:59 PST
<rdar://problem/35490085>
Matt Baker
Comment 2 2017-11-11 15:18:38 PST
Created attachment 326698 [details] [Image] Shown in rendering frames view toolbar Added to a GroupNavigationItem, to prevent dividers from being added between every checkbox item. Will check item/label spacing against native apps.
Matt Baker
Comment 3 2017-11-11 15:25:46 PST
Created attachment 326699 [details] Patch
Blaze Burg
Comment 4 2017-11-13 11:51:34 PST
Comment on attachment 326699 [details] Patch r=me
WebKit Commit Bot
Comment 5 2017-11-13 11:57:20 PST
Comment on attachment 326699 [details] Patch Clearing flags on attachment: 326699 Committed r224766: <https://trac.webkit.org/changeset/224766>
WebKit Commit Bot
Comment 6 2017-11-13 11:57:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.