Bug 179582

Summary: Remove TEC support and all TEC-only encodings except EUC-TW (which now uses ICU)
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: TextAssignee: Maciej Stachowiak <mjs>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, darin, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 179303    
Attachments:
Description Flags
Patch none

Maciej Stachowiak
Reported 2017-11-11 11:29:57 PST
The following encodings that are currently Mac-only and implemented with TEC, but are also known (by the same name) to ICU: cp950 cp737 EUC-TW The following are known to ICU by other names: ISO-2022-JP-3: JIS7 JIS_C6226-1978: ibm-942_P12A-1999 The remaining TEC encodings are unknown to ICU by any name, as far as I can tell.
Attachments
Patch (115.91 KB, patch)
2017-11-17 23:39 PST, Maciej Stachowiak 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2017-11-12 13:17:14 PST
This might also be an alternate ICU name: Shift_JIS_X0213-2000: ibm-1399_P110-2003
Maciej Stachowiak
Comment 2 2017-11-12 14:27:49 PST
New proposed plan, which I'm verifying with Apple-internal stakeholders and experts: - Switch WebKit support for EUC-TW from TEC to ICU. - Entirely remove WebKit support for all other encodings currently handled with TEC.
Maciej Stachowiak
Comment 3 2017-11-17 23:39:23 PST
Created attachment 327303 [details] Patch
WebKit Commit Bot
Comment 4 2017-11-18 19:42:53 PST
Comment on attachment 327303 [details] Patch Clearing flags on attachment: 327303 Committed r225027: <https://trac.webkit.org/changeset/225027>
WebKit Commit Bot
Comment 5 2017-11-18 19:42:55 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-11-18 19:43:22 PST
<rdar://problem/35635080>
Note You need to log in before you can comment on or make changes to this bug.