Bug 179562

Summary: We should ensure that operationStrCat2 and operationStrCat3 are never passed Symbols as arguments.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, jfbastien, keith_miller, msaboff, rmorisset, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. saam: review+

Description Mark Lam 2017-11-10 16:46:02 PST 
Patch coming soon.

<rdar://problem/35467022>
Comment 1 Mark Lam 2017-11-10 17:42:26 PST 
Created attachment 326667 [details]
proposed patch.
Comment 2 Saam Barati 2017-11-10 17:47:53 PST 
Comment on attachment 326667 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=326667&action=review

r=me

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:205
> +                    m_insertionSet.insertNode(
> +                        m_indexInBlock, SpecNone, Check, node->origin,
> +                        Edge(edge.node(), NotSymbolUse));

Might be worth a comment saying why we do this.
Comment 3 Mark Lam 2017-11-10 17:48:37 PST 
(In reply to Saam Barati from comment #2)
> > Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:205
> > +                    m_insertionSet.insertNode(
> > +                        m_indexInBlock, SpecNone, Check, node->origin,
> > +                        Edge(edge.node(), NotSymbolUse));
> 
> Might be worth a comment saying why we do this.

Thanks.  I will add the comment.
Comment 4 Mark Lam 2017-11-12 07:35:02 PST 
Landed in r224735: <http://trac.webkit.org/r224735>.