| Summary: | [Windows] Fix Python error for subprocess.popen with close_fds | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Basuke Suzuki <Basuke.Suzuki> | ||||
| Component: | Tools / Tests | Assignee: | Basuke Suzuki <Basuke.Suzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, ap, Basuke.Suzuki, bfulgham, buildbot, commit-queue, don.olmstead, glenn, Hironori.Fujii, lforschler, pvollan, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 179216 | ||||||
| Attachments: |
|
||||||
On Windows native command prompt (not Cygwin) Created attachment 326798 [details]
fix
I chose just passing False (don't close fds) because we cannot move forward with this flag True on Windows w/o Cygwin. We will figured out the actual issue caused by passing False here later. Comment on attachment 326798 [details]
fix
R=me.
Comment on attachment 326798 [details] fix Clearing flags on attachment: 326798 Committed r224795: <https://trac.webkit.org/changeset/224795> All reviewed patches have been landed. Closing bug. |
When running test-webkitpy, there're many failure caused by following error: > ValueError: close_fds is not supported on Windows platforms if you redirect stdin/stdout/stderr