Bug 179533

Summary: [GTK] Enable some passing XHR tests
Product: WebKit Reporter: Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>
Component: WebKitGTKAssignee: Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bugs-noreply, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ms2ger (he/him; ⌚ UTC+1/+2)
Reported 2017-11-10 08:59:28 PST
.
Attachments
Patch (10.94 KB, patch)
2017-11-10 09:09 PST, Ms2ger (he/him; ⌚ UTC+1/+2) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 1 2017-11-10 09:09:43 PST
Created attachment 326593 [details] Patch
Alex Christensen
Comment 2 2017-11-10 13:56:52 PST
Comment on attachment 326593 [details] Patch Are these tests passing on GTK but not on Cocoa because of bugs in CFNetwork, or because of GTK-specific code in the loader? If the latter, then we should just fix them everywhere. If the former, then we'll have to fix them internally.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 3 2017-11-13 01:08:31 PST
(In reply to Alex Christensen from comment #2) > Comment on attachment 326593 [details] > Patch > > Are these tests passing on GTK but not on Cocoa because of bugs in > CFNetwork, or because of GTK-specific code in the loader? If the latter, > then we should just fix them everywhere. If the former, then we'll have to > fix them internally. I suspect the former; I filed bug 179604 to track.
WebKit Commit Bot
Comment 4 2017-11-13 01:28:57 PST
Comment on attachment 326593 [details] Patch Clearing flags on attachment: 326593 Committed r224750: <https://trac.webkit.org/changeset/224750>
WebKit Commit Bot
Comment 5 2017-11-13 01:28:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.