Bug 179521

Summary: Rebaseline flaky / skipped service worker tests
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, ggaren, lforschler, rniwa, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=179404
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2017-11-09 21:16:37 PST
Rebaseline flaky / skipped service worker tests.
Attachments
Patch (33.58 KB, patch)
2017-11-09 21:20 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (32.10 KB, patch)
2017-11-09 21:26 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-11-09 21:20:40 PST
Created attachment 326549 [details] Patch
Chris Dumez
Comment 2 2017-11-09 21:26:38 PST
Created attachment 326551 [details] Patch
Chris Dumez
Comment 3 2017-11-09 22:06:17 PST
Committed r224663: <https://trac.webkit.org/changeset/224663>
youenn fablet
Comment 4 2017-11-09 22:26:28 PST
Comment on attachment 326551 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326551&action=review > LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https-expected.txt:25 > +CONSOLE MESSAGE: Origin https://localhost:9443 is not allowed by Access-Control-Allow-Origin. Messages here are probably not always printed in the same order due to some async nature of the test, hence the flakiness. We might probably need to use DumpConsoleLogInStderr expectation to remove this console logs. Dashboard should let us know that.
youenn fablet
Comment 5 2017-11-09 23:49:15 PST
Comment on attachment 326551 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326551&action=review > LayoutTests/TestExpectations:-169 > -imported/w3c/web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https.html [ Skip ] Test seems flaky on EWS.
Chris Dumez
Comment 6 2017-11-10 07:08:13 PST
(In reply to youenn fablet from comment #5) > Comment on attachment 326551 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326551&action=review > > > LayoutTests/TestExpectations:-169 > > -imported/w3c/web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https.html [ Skip ] > > Test seems flaky on EWS. <https://trac.webkit.org/changeset/224680>
Radar WebKit Bug Importer
Comment 7 2017-11-15 09:37:38 PST
<rdar://problem/35562091>
Note You need to log in before you can comment on or make changes to this bug.