| Summary: | Rebaseline flaky / skipped service worker tests | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | Tools / Tests | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, beidson, ggaren, lforschler, rniwa, sam, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=179404 | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2017-11-09 21:16:37 PST
Created attachment 326549 [details]
Patch
Created attachment 326551 [details]
Patch
Committed r224663: <https://trac.webkit.org/changeset/224663> Comment on attachment 326551 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326551&action=review > LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https-expected.txt:25 > +CONSOLE MESSAGE: Origin https://localhost:9443 is not allowed by Access-Control-Allow-Origin. Messages here are probably not always printed in the same order due to some async nature of the test, hence the flakiness. We might probably need to use DumpConsoleLogInStderr expectation to remove this console logs. Dashboard should let us know that. Comment on attachment 326551 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326551&action=review > LayoutTests/TestExpectations:-169 > -imported/w3c/web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https.html [ Skip ] Test seems flaky on EWS. (In reply to youenn fablet from comment #5) > Comment on attachment 326551 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326551&action=review > > > LayoutTests/TestExpectations:-169 > > -imported/w3c/web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https.html [ Skip ] > > Test seems flaky on EWS. <https://trac.webkit.org/changeset/224680> |