Summary: | REGRESSION(r224267): WebViews scheduled with custom run loop modes don't load | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | aestes, benjamin, buildbot, cdumez, cmarcelo, dbates, ggaren, koivisto, thorton, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar, Regression | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Alex Christensen
2017-11-09 17:05:22 PST
Created attachment 326521 [details]
Patch
Attachment 326521 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/NeverDestroyed.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5]
Total errors found: 1 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 326521 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326521&action=review > Source/WTF/ChangeLog:15 > + Unfortunately we need to go back to #ifdef guards because different copies of this header are included while building WTF. Wat > Source/WTF/wtf/mac/MainThreadMac.mm:125 > +static RetainPtr<NSArray<NSString *>> nsArrayFromVector(const Vector<String>& strings) The name of this function should be way more clear that it does crazy things. Created attachment 326531 [details]
Patch
Comment on attachment 326531 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326531&action=review > Source/WebCore/platform/network/mac/ResourceHandleMac.mm:277 > + RetainPtr<NSArray<NSString *>> runLoopModes; > + if (auto* scheduledPairs = d->m_context->scheduledRunLoopPairs()) { > + runLoopModes = adoptNS([[NSMutableArray alloc] initWithCapacity:scheduledPairs->size()]); > + for (auto& pair : *scheduledPairs) > + [runLoopModes addObject:(NSString *)pair->mode()]; > + } Can we just pass though the SchedulePairHashSet instead of copying into an NSArray *? Reasons to prefer: (1) A full fix for this bug requires honoring not just the run loop mode but also the run loop, which need not be the main run loop. (2) It's nice to pass C++ types to C++ code -- and faster too. Created attachment 326547 [details]
Patch
Created attachment 326550 [details]
Patch
|