Bug 179512

Summary:

build-jsc: build testmasm for all platforms using cmake

Product:

WebKit

Reporter:

Guillaume Emont <guijemont>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, lforschler, mcatanzaro, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description Guillaume Emont 2017-11-09 16:38:12 PST

As of now, when using cmake, build-jsc only builds testmasm on windows. On the other platforms it builds testb3 testair testapi but not testmasm.

Comment 1 Guillaume Emont 2017-11-09 16:42:13 PST

Created attachment 326509 [details]
Patch

Patch fixing the issue.

Comment 2 Guillaume Emont 2017-11-09 16:44:06 PST

Created attachment 326510 [details]
Patch

Corrected patch that includes ChangeLog update.

Comment 3 Guillaume Emont 2017-11-09 19:06:57 PST

Created attachment 326532 [details]
Patch

Comment 4 Guillaume Emont 2017-11-09 19:08:11 PST

Sorry for the noise, it took me a while to realize that webkit-patch does not quite work when run from Tools/Scripts, or something like that. Now I finally have the patch I meant to upload ;)

Comment 5 WebKit Commit Bot 2017-11-10 08:29:24 PST

Comment on attachment 326532 [details]
Patch

Clearing flags on attachment: 326532

Committed r224683: <https://trac.webkit.org/changeset/224683>

Comment 6 WebKit Commit Bot 2017-11-10 08:29:25 PST

All reviewed patches have been landed.  Closing bug.

Comment 7 Radar WebKit Bug Importer 2017-11-15 09:44:47 PST

<rdar://problem/35562350>