Bug 179512

Summary: build-jsc: build testmasm for all platforms using cmake
Product: WebKit Reporter: Guillaume Emont <guijemont>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lforschler, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Guillaume Emont
Reported 2017-11-09 16:38:12 PST
As of now, when using cmake, build-jsc only builds testmasm on windows. On the other platforms it builds testb3 testair testapi but not testmasm.
Attachments
Patch (704 bytes, patch)
2017-11-09 16:42 PST, Guillaume Emont 		no flags
DetailsFormatted DiffDiff
Patch (704 bytes, patch)
2017-11-09 16:44 PST, Guillaume Emont 		no flags
DetailsFormatted DiffDiff
Patch (1.22 KB, patch)
2017-11-09 19:06 PST, Guillaume Emont 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Guillaume Emont
Comment 1 2017-11-09 16:42:13 PST
Created attachment 326509 [details] Patch Patch fixing the issue.
Guillaume Emont
Comment 2 2017-11-09 16:44:06 PST
Created attachment 326510 [details] Patch Corrected patch that includes ChangeLog update.
Guillaume Emont
Comment 3 2017-11-09 19:06:57 PST
Created attachment 326532 [details] Patch
Guillaume Emont
Comment 4 2017-11-09 19:08:11 PST
Sorry for the noise, it took me a while to realize that webkit-patch does not quite work when run from Tools/Scripts, or something like that. Now I finally have the patch I meant to upload ;)
WebKit Commit Bot
Comment 5 2017-11-10 08:29:24 PST
Comment on attachment 326532 [details] Patch Clearing flags on attachment: 326532 Committed r224683: <https://trac.webkit.org/changeset/224683>
WebKit Commit Bot
Comment 6 2017-11-10 08:29:25 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-11-15 09:44:47 PST
<rdar://problem/35562350>
Note You need to log in before you can comment on or make changes to this bug.