Bug 179512 - build-jsc: build testmasm for all platforms using cmake
Summary: build-jsc: build testmasm for all platforms using cmake
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-09 16:38 PST by Guillaume Emont
Modified: 2017-11-15 09:44 PST (History)
4 users (show)

See Also:

Attachments
Patch (704 bytes, patch)
2017-11-09 16:42 PST, Guillaume Emont 		no flags Details | Formatted Diff | Diff
Patch (704 bytes, patch)
2017-11-09 16:44 PST, Guillaume Emont 		no flags Details | Formatted Diff | Diff
Patch (1.22 KB, patch)
2017-11-09 19:06 PST, Guillaume Emont 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guillaume Emont 2017-11-09 16:38:12 PST 
As of now, when using cmake, build-jsc only builds testmasm on windows. On the other platforms it builds testb3 testair testapi but not testmasm.
Comment 1 Guillaume Emont 2017-11-09 16:42:13 PST 
Created attachment 326509 [details]
Patch

Patch fixing the issue.
Comment 2 Guillaume Emont 2017-11-09 16:44:06 PST 
Created attachment 326510 [details]
Patch

Corrected patch that includes ChangeLog update.
Comment 3 Guillaume Emont 2017-11-09 19:06:57 PST 
Created attachment 326532 [details]
Patch
Comment 4 Guillaume Emont 2017-11-09 19:08:11 PST 
Sorry for the noise, it took me a while to realize that webkit-patch does not quite work when run from Tools/Scripts, or something like that. Now I finally have the patch I meant to upload ;)
Comment 5 WebKit Commit Bot 2017-11-10 08:29:24 PST 
Comment on attachment 326532 [details]
Patch

Clearing flags on attachment: 326532

Committed r224683: <https://trac.webkit.org/changeset/224683>
Comment 6 WebKit Commit Bot 2017-11-10 08:29:25 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-11-15 09:44:47 PST 
<rdar://problem/35562350>