Bug 179507

Summary: Web Inspector: Styles Redesign: clicking on inline swatches and property checkboxes should not add a new property
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Animated GIF] Bug
none
Patch
none
[Animated GIF] With patch applied none

Nikita Vasilyev
Reported 2017-11-09 14:14:52 PST
Created attachment 326487 [details] [Animated GIF] Bug Clicking on the whitespace on the right side of a property should insert a blank property after the clicked one. Clicking on inline swatches (e.g. a color picker) and property checkboxes (which disable/enable properties) should not add a new property.
Attachments
[Animated GIF] Bug (338.94 KB, image/gif)
2017-11-09 14:14 PST, Nikita Vasilyev 		no flags
Details
Patch (4.96 KB, patch)
2017-11-09 14:40 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Animated GIF] With patch applied (223.94 KB, image/gif)
2017-11-09 14:48 PST, Nikita Vasilyev 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-11-09 14:15:15 PST
<rdar://problem/35452204>
Nikita Vasilyev
Comment 2 2017-11-09 14:40:38 PST
Created attachment 326489 [details] Patch
Nikita Vasilyev
Comment 3 2017-11-09 14:48:47 PST
Created attachment 326490 [details] [Animated GIF] With patch applied
Blaze Burg
Comment 4 2017-11-09 15:31:11 PST
Comment on attachment 326489 [details] Patch r=me, thanks for fixing this! it was bugging me but I forgot to file a bug.
WebKit Commit Bot
Comment 5 2017-11-09 15:40:55 PST
Comment on attachment 326489 [details] Patch Clearing flags on attachment: 326489 Committed r224651: <https://trac.webkit.org/changeset/224651>
WebKit Commit Bot
Comment 6 2017-11-09 15:40:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.