Bug 179507

Summary: Web Inspector: Styles Redesign: clicking on inline swatches and property checkboxes should not add a new property
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Animated GIF] Bug
none
Patch
none
[Animated GIF] With patch applied none

Description Nikita Vasilyev 2017-11-09 14:14:52 PST
Created attachment 326487 [details]
[Animated GIF] Bug

Clicking on the whitespace on the right side of a property should insert a blank property after the clicked one.
Clicking on inline swatches (e.g. a color picker) and property checkboxes (which disable/enable properties) should not add a new property.
Comment 1 Radar WebKit Bug Importer 2017-11-09 14:15:15 PST
<rdar://problem/35452204>
Comment 2 Nikita Vasilyev 2017-11-09 14:40:38 PST
Created attachment 326489 [details]
Patch
Comment 3 Nikita Vasilyev 2017-11-09 14:48:47 PST
Created attachment 326490 [details]
[Animated GIF] With patch applied
Comment 4 BJ Burg 2017-11-09 15:31:11 PST
Comment on attachment 326489 [details]
Patch

r=me, thanks for fixing this! it was bugging me but I forgot to file a bug.
Comment 5 WebKit Commit Bot 2017-11-09 15:40:55 PST
Comment on attachment 326489 [details]
Patch

Clearing flags on attachment: 326489

Committed r224651: <https://trac.webkit.org/changeset/224651>
Comment 6 WebKit Commit Bot 2017-11-09 15:40:56 PST
All reviewed patches have been landed.  Closing bug.