Bug 179507 - Web Inspector: Styles Redesign: clicking on inline swatches and property checkboxes should not add a new property
Summary: Web Inspector: Styles Redesign: clicking on inline swatches and property chec...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-09 14:14 PST by Nikita Vasilyev
Modified: 2017-11-09 15:40 PST (History)
4 users (show)

See Also:

Attachments
[Animated GIF] Bug (338.94 KB, image/gif)
2017-11-09 14:14 PST, Nikita Vasilyev 		no flags Details
Patch (4.96 KB, patch)
2017-11-09 14:40 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Animated GIF] With patch applied (223.94 KB, image/gif)
2017-11-09 14:48 PST, Nikita Vasilyev 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2017-11-09 14:14:52 PST 
Created attachment 326487 [details]
[Animated GIF] Bug

Clicking on the whitespace on the right side of a property should insert a blank property after the clicked one.
Clicking on inline swatches (e.g. a color picker) and property checkboxes (which disable/enable properties) should not add a new property.
Comment 1 Radar WebKit Bug Importer 2017-11-09 14:15:15 PST 
<rdar://problem/35452204>
Comment 2 Nikita Vasilyev 2017-11-09 14:40:38 PST 
Created attachment 326489 [details]
Patch
Comment 3 Nikita Vasilyev 2017-11-09 14:48:47 PST 
Created attachment 326490 [details]
[Animated GIF] With patch applied
Comment 4 Blaze Burg 2017-11-09 15:31:11 PST 
Comment on attachment 326489 [details]
Patch

r=me, thanks for fixing this! it was bugging me but I forgot to file a bug.
Comment 5 WebKit Commit Bot 2017-11-09 15:40:55 PST 
Comment on attachment 326489 [details]
Patch

Clearing flags on attachment: 326489

Committed r224651: <https://trac.webkit.org/changeset/224651>
Comment 6 WebKit Commit Bot 2017-11-09 15:40:56 PST 
All reviewed patches have been landed.  Closing bug.