Summary: | Make CachedResource::redirectReceived asynchronous | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | koivisto, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Alex Christensen
2017-11-09 12:02:00 PST
Created attachment 326475 [details]
Patch
Created attachment 326479 [details]
Patch
Comment on attachment 326479 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326479&action=review > Source/WebCore/loader/SubresourceLoader.cpp:186 > + auto callSuper = [this, protectedThis = makeRef(*this), redirectResponse] (CompletionHandler<void(ResourceRequest&&)>&& completionHandler, ResourceRequest&& newRequest) mutable { "callSuper" is not a great name. Can you name this with something that describes what it is actually trying to accomplish? > Source/WebCore/loader/cache/CachedRawResource.cpp:119 > +static void iterate(CachedResourceHandle<CachedRawResource>&& handle, CachedRawResourceClient& client, Vector<std::pair<ResourceRequest, ResourceResponse>>&& redirectsInReverseOrder, CompletionHandler<void(ResourceRequest&&)>&& completionHandler) iterate over what? (In reply to Antti Koivisto from comment #3) > "callSuper" is not a great name. Can you name this with something that > describes what it is actually trying to accomplish? I renamed this to continueWillSendRequest. > iterate over what? I renamed these to iterateClients and iterateRedirects. http://trac.webkit.org/r224699 |