Bug 179487

Summary: FetchResponse should set the mime type of its internal ResourceResponse
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

youenn fablet
Reported 2017-11-09 09:17:09 PST
This mime type is used for navigation tasks. If going through Service Worker, the mime type would not be set now.
Attachments
Patch (1.88 KB, patch)
2017-11-09 09:26 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (3.42 KB, patch)
2017-11-09 09:36 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (1.91 KB, patch)
2017-11-09 12:30 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-11-09 09:26:21 PST
Created attachment 326457 [details] Patch
youenn fablet
Comment 2 2017-11-09 09:36:58 PST
Created attachment 326459 [details] Patch
Chris Dumez
Comment 3 2017-11-09 10:50:25 PST
Comment on attachment 326459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326459&action=review > Source/WebCore/platform/network/ResourceResponseBase.h:82 > + void sniffMimeTypeIfNeeded(const String& contentType); Not a fan of having a sniffing method on the resourceResponse itself.
youenn fablet
Comment 4 2017-11-09 12:30:38 PST
Created attachment 326478 [details] Patch
WebKit Commit Bot
Comment 5 2017-11-09 13:09:27 PST
Comment on attachment 326478 [details] Patch Clearing flags on attachment: 326478 Committed r224645: <https://trac.webkit.org/changeset/224645>
WebKit Commit Bot
Comment 6 2017-11-09 13:09:29 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-11-15 09:38:09 PST
<rdar://problem/35562115>
Note You need to log in before you can comment on or make changes to this bug.