| Summary: | ServiceWorker ResourceResponse should not assert in platformCertificateInfo() | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | beidson, cdumez, commit-queue, sam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2017-11-09 09:13:43 PST
Created attachment 326455 [details]
Patch
Comment on attachment 326455 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326455&action=review > Source/WebCore/ChangeLog:10 > + In that case, platformCertificateInfo should return std::nullopt. platformCertificateInfo doesn't return an optional, so I don't think this makes sense. It just returns a default constructed CertificateInfo. Created attachment 326473 [details]
Patch
Comment on attachment 326473 [details] Patch Clearing flags on attachment: 326473 Committed r224644: <https://trac.webkit.org/changeset/224644> All reviewed patches have been landed. Closing bug. |