Bug 179484

Summary:

[LayoutState cleanup] LayoutState::m_lineGrid should be a weak pointer

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, darin, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description zalan 2017-11-09 09:03:06 PST

ssia.

Comment 1 Radar WebKit Bug Importer 2017-11-09 09:04:15 PST

<rdar://problem/35442725>

Comment 2 zalan 2017-11-09 09:13:00 PST

Created attachment 326454 [details]
Patch

Comment 3 Darin Adler 2017-11-09 09:22:36 PST

Comment on attachment 326454 [details]
Patch

Didn’t need to add any null checks?

Comment 4 zalan 2017-11-09 10:02:40 PST

(In reply to Darin Adler from comment #3)
> Comment on attachment 326454 [details]
> Patch
> 
> Didn’t need to add any null checks?
We already check for null on m_lineGrid.

Comment 5 WebKit Commit Bot 2017-11-09 10:22:01 PST

Comment on attachment 326454 [details]
Patch

Clearing flags on attachment: 326454

Committed r224632: <https://trac.webkit.org/changeset/224632>

Comment 6 WebKit Commit Bot 2017-11-09 10:22:03 PST

All reviewed patches have been landed.  Closing bug.