Bug 179483

Summary: [LayoutState cleanup] Remove renderer data members from state maintainers.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, darin, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description zalan 2017-11-09 08:53:33 PST
Although layout is not supposed to mutate the tree, it's safer not to have them as data members.
Comment 1 Radar WebKit Bug Importer 2017-11-09 08:55:46 PST
<rdar://problem/35442548>
Comment 2 zalan 2017-11-09 08:58:26 PST
Created attachment 326452 [details]
Patch
Comment 3 Darin Adler 2017-11-09 09:25:57 PST
Comment on attachment 326452 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326452&action=review

> Source/WebCore/rendering/LayoutState.h:165
> +    LayoutContext* m_layoutContext { nullptr };

I would have just called this "m_acontext" since the class is all about layout and has layout in its name.

> Source/WebCore/rendering/LayoutState.h:185
> +    LayoutContext& m_layoutContext;

Ditto.
Comment 4 zalan 2017-11-09 10:03:25 PST
(In reply to Darin Adler from comment #3)
> Comment on attachment 326452 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=326452&action=review
> 
> > Source/WebCore/rendering/LayoutState.h:165
> > +    LayoutContext* m_layoutContext { nullptr };
> 
> I would have just called this "m_acontext" since the class is all about
> layout and has layout in its name.
Indeed.
Comment 5 zalan 2017-11-09 10:27:34 PST
Created attachment 326465 [details]
Patch
Comment 6 WebKit Commit Bot 2017-11-09 10:50:07 PST
Comment on attachment 326465 [details]
Patch

Clearing flags on attachment: 326465

Committed r224637: <https://trac.webkit.org/changeset/224637>
Comment 7 WebKit Commit Bot 2017-11-09 10:50:09 PST
All reviewed patches have been landed.  Closing bug.