Summary: | [LayoutState cleanup] Remove renderer data members from state maintainers. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, darin, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
zalan
2017-11-09 08:53:33 PST
Created attachment 326452 [details]
Patch
Comment on attachment 326452 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326452&action=review > Source/WebCore/rendering/LayoutState.h:165 > + LayoutContext* m_layoutContext { nullptr }; I would have just called this "m_acontext" since the class is all about layout and has layout in its name. > Source/WebCore/rendering/LayoutState.h:185 > + LayoutContext& m_layoutContext; Ditto. (In reply to Darin Adler from comment #3) > Comment on attachment 326452 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326452&action=review > > > Source/WebCore/rendering/LayoutState.h:165 > > + LayoutContext* m_layoutContext { nullptr }; > > I would have just called this "m_acontext" since the class is all about > layout and has layout in its name. Indeed. Created attachment 326465 [details]
Patch
Comment on attachment 326465 [details] Patch Clearing flags on attachment: 326465 Committed r224637: <https://trac.webkit.org/changeset/224637> All reviewed patches have been landed. Closing bug. |