Bug 179457

Summary: Web Inspector: Make domain availability a list of types instead of a single type
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, buildbot, commit-queue, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2017-11-08 16:40:58 PST
Make domain availability a list of types instead of a single type The intent of this change is to make it so the Network domain will be available in both a "web" and "service-worker" domain but not a "javascript" domain. This changes: InspectorBackend.activateDomain("Network", "web"); to: InspectorBackend.activateDomain("Network", ["web"]); And later we will be able to do: InspectorBackend.activateDomain("Network", ["web", "service-worker"]);
Attachments
[PATCH] Proposed Fix (99.08 KB, patch)
2017-11-08 16:45 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-11-08 16:45:51 PST
Created attachment 326404 [details] [PATCH] Proposed Fix
Build Bot
Comment 2 2017-11-08 16:47:38 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Blaze Burg
Comment 3 2017-11-09 10:11:16 PST
Comment on attachment 326404 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 4 2017-11-09 10:32:30 PST
Comment on attachment 326404 [details] [PATCH] Proposed Fix Clearing flags on attachment: 326404 Committed r224634: <https://trac.webkit.org/changeset/224634>
WebKit Commit Bot
Comment 5 2017-11-09 10:32:32 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-11-15 09:38:32 PST
<rdar://problem/35562135>
Note You need to log in before you can comment on or make changes to this bug.