Summary: | REGRESSION(r224534): Crash inside Document::updateStyleIfNeeded | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | New Bugs | Assignee: | Ryosuke Niwa <rniwa> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, buildbot, cdumez, commit-queue, dbates, esprehn+autocc, kangil.han, simon.fraser | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=179651 | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2017-11-08 13:19:13 PST
Created attachment 326355 [details]
Disable assertins in iOS
Comment on attachment 326355 [details] Disable assertins in iOS Clearing flags on attachment: 326355 Committed r224604: <https://trac.webkit.org/changeset/224604> All reviewed patches have been landed. Closing bug. Comment on attachment 326355 [details] Disable assertins in iOS View in context: https://bugs.webkit.org/attachment.cgi?id=326355&action=review > Source/WebCore/dom/Document.cpp:1942 > +#if !USE(WEB_THREAD) How does this work? We don't have separate WebCore builds for WebKit2 and legacy WebKit, so won't this completely disable the assertion on iOS? Yes, it does. We plan to re-enable the assertion after some bug fixing. (In reply to Alexey Proskuryakov from comment #5) > Comment on attachment 326355 [details] > Disable assertins in iOS > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326355&action=review > > > Source/WebCore/dom/Document.cpp:1942 > > +#if !USE(WEB_THREAD) > > How does this work? We don't have separate WebCore builds for WebKit2 and > legacy WebKit, so won't this completely disable the assertion on iOS? Yes. That's the intent to unblock the submission. I intend on fixing the assertion next week when I actually have an engineering time. |