Bug 179418

Summary: HTMLMediaElement should not use element fullscreen on iOS
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: MediaAssignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, darin, eric.carlson, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Jeremy Jones 2017-11-08 01:15:02 PST 
HTMLMediaElement should not use element fullscreen on iOS
Comment 1 Jeremy Jones 2017-11-08 01:15:39 PST 
rdar://problem/35409277
Comment 2 Jeremy Jones 2017-11-08 01:18:16 PST 
Created attachment 326315 [details]
Patch
Comment 3 Darin Adler 2017-11-08 09:30:14 PST 
Comment on attachment 326315 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326315&action=review

> Source/WebCore/ChangeLog:9
> +        Add a setting videoUsesElementFullScreen to determine if HTMLMediaElement should use element full screen or not.

What’s the rationale behind using a setting instead of a compile time switch?
Comment 4 Jeremy Jones 2017-11-08 12:44:33 PST 
(In reply to Darin Adler from comment #3)
> Comment on attachment 326315 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=326315&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        Add a setting videoUsesElementFullScreen to determine if HTMLMediaElement should use element full screen or not.
> 
> What’s the rationale behind using a setting instead of a compile time switch?

Originally I though there might be clients that wanted to control how videos were presented. But we don't actually have a use case for that. I'll change this to be a compile time switch.
Comment 5 Jeremy Jones 2017-11-08 13:16:07 PST 
Created attachment 326354 [details]
Patch
Comment 6 Jeremy Jones 2017-11-08 14:00:10 PST 
Created attachment 326368 [details]
Patch
Comment 7 Build Bot 2017-11-08 14:02:11 PST 
Attachment 326368 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:1:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Jeremy Jones 2017-11-08 14:05:55 PST 
Created attachment 326369 [details]
Patch
Comment 9 WebKit Commit Bot 2017-11-08 16:43:39 PST 
Comment on attachment 326369 [details]
Patch

Clearing flags on attachment: 326369

Committed r224607: <https://trac.webkit.org/changeset/224607>
Comment 10 WebKit Commit Bot 2017-11-08 16:43:40 PST 
All reviewed patches have been landed.  Closing bug.