| Summary: | [LayoutState cleanup] LayoutContext should own the stack of LayoutState objects | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bfulgham, buildbot, commit-queue, koivisto, rniwa, simon.fraser, webkit-bug-importer, zalan | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
zalan
2017-11-07 21:06:53 PST
Created attachment 326364 [details]
Patch
Comment on attachment 326364 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326364&action=review > Source/WebCore/rendering/LayoutState.cpp:130 > +void LayoutState::computePaginationInformation(const LayoutContext::LayoutStateStack& layoutStateStack, RenderBox& renderer, LayoutUnit pageLogicalHeight, bool pageLogicalHeightChanged) Please move this function out of the LayoutState at some point. Comment on attachment 326364 [details] Patch Attachment 326364 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5153011 New failing tests: fast/line-grid/line-grid-into-columns.html Created attachment 326383 [details]
Archive of layout-test-results from ews100 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 326401 [details]
Patch
Comment on attachment 326401 [details] Patch Clearing flags on attachment: 326401 Committed r224612: <https://trac.webkit.org/changeset/224612> All reviewed patches have been landed. Closing bug. |