Bug 179406

Summary: Disable implicit animations when adding or removing text track representation layers.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: MediaAssignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jer.noble, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Jeremy Jones 2017-11-07 19:34:38 PST
Disable implicit animations when adding or removing text track representation layers.
Comment 1 Jeremy Jones 2017-11-07 19:35:18 PST
rdar://problem/34369835
Comment 2 Jeremy Jones 2017-11-07 19:38:29 PST
Created attachment 326291 [details]
Patch
Comment 3 Simon Fraser (smfr) 2017-11-07 21:59:04 PST
Comment on attachment 326291 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326291&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1238
> +    [CATransaction begin];
> +    [CATransaction setDisableActions:YES];

Maybe we should make a stack-based class that does this.
Comment 4 WebKit Commit Bot 2017-11-08 01:49:06 PST
Comment on attachment 326291 [details]
Patch

Clearing flags on attachment: 326291

Committed r224574: <https://trac.webkit.org/changeset/224574>
Comment 5 WebKit Commit Bot 2017-11-08 01:49:07 PST
All reviewed patches have been landed.  Closing bug.