| Summary: | Add a WinCairo EWS queue | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||
| Component: | Tools / Tests | Assignee: | Don Olmstead <don.olmstead> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, buildbot, commit-queue, glenn, lforschler, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Don Olmstead
2017-11-07 13:43:21 PST
Created attachment 326255 [details]
Patch
Created attachment 326258 [details]
Patch
Fix copy paste error
Comment on attachment 326258 [details] Patch Clearing flags on attachment: 326258 Committed r224549: <https://trac.webkit.org/changeset/224549> All reviewed patches have been landed. Closing bug. I will update the server to pick up the changes tonight. This breaks webkitpy tests (./Tools/Scripts/test-webkitpy).
Seems like the unit-test inside config/ports_unittest.py needs some modifications related to extra arguments in the end ("--wincairo", DeprecatedPort().makeArgs()).
[53/1658] webkitpy.common.config.ports_unittest.DeprecatedPortTest.test_wincairo_port failed:
Traceback (most recent call last):
File "/Users/aakashjain/code/OpenSource/Tools/Scripts/webkitpy/common/config/ports_unittest.py", line 61, in test_wincairo_port
self.assertEqual(WinCairoPort().run_webkit_tests_command(), DeprecatedPort().script_shell_command("run-webkit-tests") + ["--wincairo"])
AssertionError: Lists differ: ['Tools/Scripts/run-webkit-tes... != ['Tools/Scripts/run-webkit-tes...
Second list contains 1 additional elements.
First extra element 1:
--wincairo
- ['Tools/Scripts/run-webkit-tests']
+ ['Tools/Scripts/run-webkit-tests', '--wincairo']
? ++++++++++++++
|