Bug 179390

Summary: Add a WinCairo EWS queue
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, buildbot, commit-queue, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Don Olmstead
Reported 2017-11-07 13:43:21 PST
Adding a WinCairo EWS queue will help us detect build failures early
Attachments
Patch (5.00 KB, patch)
2017-11-07 13:47 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (5.02 KB, patch)
2017-11-07 14:04 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2017-11-07 13:47:05 PST
Created attachment 326255 [details] Patch
Don Olmstead
Comment 2 2017-11-07 14:04:09 PST
Created attachment 326258 [details] Patch Fix copy paste error
WebKit Commit Bot
Comment 3 2017-11-07 14:38:37 PST
Comment on attachment 326258 [details] Patch Clearing flags on attachment: 326258 Committed r224549: <https://trac.webkit.org/changeset/224549>
WebKit Commit Bot
Comment 4 2017-11-07 14:38:39 PST
All reviewed patches have been landed. Closing bug.
Aakash Jain
Comment 5 2017-11-07 14:42:11 PST
I will update the server to pick up the changes tonight.
Aakash Jain
Comment 6 2017-11-07 15:52:36 PST
This breaks webkitpy tests (./Tools/Scripts/test-webkitpy). Seems like the unit-test inside config/ports_unittest.py needs some modifications related to extra arguments in the end ("--wincairo", DeprecatedPort().makeArgs()). [53/1658] webkitpy.common.config.ports_unittest.DeprecatedPortTest.test_wincairo_port failed: Traceback (most recent call last): File "/Users/aakashjain/code/OpenSource/Tools/Scripts/webkitpy/common/config/ports_unittest.py", line 61, in test_wincairo_port self.assertEqual(WinCairoPort().run_webkit_tests_command(), DeprecatedPort().script_shell_command("run-webkit-tests") + ["--wincairo"]) AssertionError: Lists differ: ['Tools/Scripts/run-webkit-tes... != ['Tools/Scripts/run-webkit-tes... Second list contains 1 additional elements. First extra element 1: --wincairo - ['Tools/Scripts/run-webkit-tests'] + ['Tools/Scripts/run-webkit-tests', '--wincairo'] ? ++++++++++++++
Radar WebKit Bug Importer
Comment 7 2017-11-15 09:40:56 PST
<rdar://problem/35562217>
Note You need to log in before you can comment on or make changes to this bug.