Bug 179380

Summary:

[LayoutState cleanup] Remove explicit LayoutStateMaintainer::pop calls.

Product:

WebKit

Reporter:

alan <zalan>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, commit-queue, koivisto, rniwa, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews103 for mac-elcapitan	none
Archive of layout-test-results from ews115 for mac-elcapitan	none
Patch	none

alan

Reported 2017-11-07 11:09:32 PST

and move it to the LayoutStateMaintainer d'tor

Attachments
Patch (44.41 KB, patch) 2017-11-07 11:18 PST, alan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-elcapitan (2.19 MB, application/zip) 2017-11-07 12:14 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-elcapitan (3.24 MB, application/zip) 2017-11-07 13:03 PST, Build Bot	no flags	Details
Patch (47.36 KB, patch) 2017-11-07 13:04 PST, alan	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-11-07 11:10:52 PST

<rdar://problem/35392161>

alan

Comment 2 2017-11-07 11:18:54 PST

Created attachment 326224 [details] Patch

Antti Koivisto

Comment 3 2017-11-07 11:55:47 PST

Comment on attachment 326224 [details] Patch r=me

Build Bot

Comment 4 2017-11-07 12:14:45 PST

Comment on attachment 326224 [details] Patch Attachment 326224 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5136984 New failing tests: fast/repaint/align-items-change.html

Build Bot

Comment 5 2017-11-07 12:14:46 PST

Created attachment 326236 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-11-07 13:03:13 PST

Comment on attachment 326224 [details] Patch Attachment 326224 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5137143 New failing tests: fast/repaint/align-items-change.html

Build Bot

Comment 7 2017-11-07 13:03:14 PST

Created attachment 326246 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6

alan

Comment 8 2017-11-07 13:04:00 PST

Created attachment 326247 [details] Patch

WebKit Commit Bot

Comment 9 2017-11-07 13:36:11 PST

Comment on attachment 326247 [details] Patch Clearing flags on attachment: 326247 Committed r224546: <https://trac.webkit.org/changeset/224546>

WebKit Commit Bot

Comment 10 2017-11-07 13:36:12 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.