Summary: | Web Inspector: Create inspector agents lazily | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | buildbot, commit-queue, inspector-bugzilla-changes, joepeck, sam, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2017-11-06 19:43:36 PST
Created attachment 326186 [details]
[PATCH] Proposed Fix
Attachment 326186 [details] did not pass style-queue:
ERROR: Source/WebCore/inspector/InspectorController.cpp:154: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 326186 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=326186&action=review > Source/WebCore/inspector/InspectorController.cpp:153 > - commandLineAPIHost->init(m_inspectorAgent > + commandLineAPIHost->init( I can make this all one line now. It used to be split up because of ENABLE guards that no longer exist. Comment on attachment 326186 [details] [PATCH] Proposed Fix Clearing flags on attachment: 326186 Committed r224530: <https://trac.webkit.org/changeset/224530> All reviewed patches have been landed. Closing bug. |