|Summary:||Web Inspector: Create inspector agents lazily|
|Product:||WebKit||Reporter:||Joseph Pecoraro <joepeck>|
|Component:||Web Inspector||Assignee:||Joseph Pecoraro <joepeck>|
|Severity:||Normal||CC:||buildbot, commit-queue, inspector-bugzilla-changes, joepeck, sam, webkit-bug-importer|
|Version:||WebKit Nightly Build|
Description Joseph Pecoraro 2017-11-06 19:43:36 PST
Create inspector agents lazily Move some agents to be created lazily. We don't need these to be created along with the WebCore::Page since they are only needed when an inspector frontend connects. Our goal should be to move more and more of these to be lazily created.
Comment 1 Joseph Pecoraro 2017-11-06 19:45:01 PST
Created attachment 326186 [details] [PATCH] Proposed Fix
Comment 2 Build Bot 2017-11-06 19:47:12 PST
Attachment 326186 [details] did not pass style-queue: ERROR: Source/WebCore/inspector/InspectorController.cpp:154: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent]  Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Joseph Pecoraro 2017-11-06 20:02:57 PST
Comment on attachment 326186 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=326186&action=review > Source/WebCore/inspector/InspectorController.cpp:153 > - commandLineAPIHost->init(m_inspectorAgent > + commandLineAPIHost->init( I can make this all one line now. It used to be split up because of ENABLE guards that no longer exist.
Comment 4 WebKit Commit Bot 2017-11-07 01:32:18 PST
Comment on attachment 326186 [details] [PATCH] Proposed Fix Clearing flags on attachment: 326186 Committed r224530: <https://trac.webkit.org/changeset/224530>
Comment 5 WebKit Commit Bot 2017-11-07 01:32:19 PST
All reviewed patches have been landed. Closing bug.