Bug 179349

Summary:

Only build ImageDiff for mac

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, lforschler, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Jonathan Bedard 2017-11-06 16:01:47 PST

ImageDiff should usually be built for the platform of the machine doing the building, not the target SDK.

Comment 1 Radar WebKit Bug Importer 2017-11-06 16:04:03 PST

<rdar://problem/35376244>

Comment 2 Radar WebKit Bug Importer 2017-11-06 16:04:32 PST

<rdar://problem/35376237>

Comment 3 Jonathan Bedard 2017-11-06 16:12:32 PST

Created attachment 326166 [details]
Patch

Comment 4 WebKit Commit Bot 2017-11-06 16:48:44 PST

Comment on attachment 326166 [details]
Patch

Clearing flags on attachment: 326166

Committed r224518: <https://trac.webkit.org/changeset/224518>

Comment 5 WebKit Commit Bot 2017-11-06 16:48:46 PST

All reviewed patches have been landed.  Closing bug.