Bug 179349

Summary: Only build ImageDiff for mac
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lforschler, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2017-11-06 16:01:47 PST
ImageDiff should usually be built for the platform of the machine doing the building, not the target SDK.
Attachments
Patch (1.11 KB, patch)
2017-11-06 16:12 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-11-06 16:04:03 PST
<rdar://problem/35376244>
Radar WebKit Bug Importer
Comment 2 2017-11-06 16:04:32 PST
<rdar://problem/35376237>
Jonathan Bedard
Comment 3 2017-11-06 16:12:32 PST
Created attachment 326166 [details] Patch
WebKit Commit Bot
Comment 4 2017-11-06 16:48:44 PST
Comment on attachment 326166 [details] Patch Clearing flags on attachment: 326166 Committed r224518: <https://trac.webkit.org/changeset/224518>
WebKit Commit Bot
Comment 5 2017-11-06 16:48:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.