Bug 179292

Summary: REGRESSION (r221338): Web Inspector: NavigationBar incorrectly calculates minimumWidth
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 174229    
Attachments:
Description Flags
Patch none

Nikita Vasilyev
Reported 2017-11-04 17:47:59 PDT
Regressed in http://trac.webkit.org/changeset/221338 (is there a way to link to the particular line on that Trac page?) https://github.com/WebKit/webkit/commit/0658355ecdb6d2a5124409ca09611c489214b680#diff-c25e9ae6392f7d5378a5d218d4b2522bL372 let totalItemWidth = this._visibleNavigationItems.reduce((total, item) => item.minimumWidth, 0); totalItemWidth here is always minimumWidth of the last item.
Attachments
Patch (1.54 KB, patch)
2017-11-04 17:51 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2017-11-04 17:51:50 PDT
Created attachment 326054 [details] Patch
Nikita Vasilyev
Comment 2 2017-11-05 13:06:36 PST
This regression had no user impact in US English localization because WI.Sidebar.AbsoluteMinimumWidth of 200px provided sufficient width to fit all navigation items in our sidebars. There could have been issues with other localizations.
Devin Rousso
Comment 3 2017-11-05 22:45:00 PST
Comment on attachment 326054 [details] Patch r=me
WebKit Commit Bot
Comment 4 2017-11-05 23:04:05 PST
Comment on attachment 326054 [details] Patch Clearing flags on attachment: 326054 Committed r224481: <https://trac.webkit.org/changeset/224481>
WebKit Commit Bot
Comment 5 2017-11-05 23:04:06 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-11-15 12:11:32 PST
<rdar://problem/35567113>
Note You need to log in before you can comment on or make changes to this bug.