Bug 179282 – [LayoutState cleanup] Move m_layoutState from RenderView to LayoutContext

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

It does not really belong to RenderView.

[Radar WebKit Bug Importer]

<rdar://problem/35348653>

[alan]

Created attachment 326058 [details]
Patch

[Build Bot]

Attachment 326058 [details] did not pass style-queue:


ERROR: Source/WebCore/style/RenderTreeUpdaterFirstLetter.cpp:223:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/style/RenderTreeUpdaterListItem.cpp:74:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
Total errors found: 2 in 34 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Comment on attachment 326058 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326058&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:741
> +    bool paginated = view().frameView().layoutContext().layoutState()->isPaginated();

If this wasn't temporary we'd want layoutState() helper.

[WebKit Commit Bot]

Comment on attachment 326058 [details]
Patch

Clearing flags on attachment: 326058

Committed r224494: <https://trac.webkit.org/changeset/224494>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

This change appears to have caused flakiness with LayoutTests in the fast/repaint directory on WK1. Example of failures:
https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r224495%20(4699)/results.html

[Ryan Haddad]

(In reply to Ryan Haddad from comment #7)
> This change appears to have caused flakiness with LayoutTests in the
> fast/repaint directory on WK1. Example of failures:
> https://build.webkit.org/results/
> Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r224495%20(4699)/results.html
I can repro locally with a build of r224494 with the following command:

run-webkit-tests -1 fast/repaint/transform-table-layout.html fast/repaint/focus-ring-repaint.html --iter 200 --no-retry-failure

[Ryan Haddad]

Reverted r224494 for reason:

Introduced LayoutTest flakiness on WK1.

Committed r224511: <https://trac.webkit.org/changeset/224511>

[alan]

Created attachment 326183 [details]
Patch

[Build Bot]

Attachment 326183 [details] did not pass style-queue:


ERROR: Source/WebCore/style/RenderTreeUpdaterFirstLetter.cpp:223:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/style/RenderTreeUpdaterListItem.cpp:74:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
Total errors found: 2 in 34 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[alan]

(In reply to Ryan Haddad from comment #9)
> Reverted r224494 for reason:
> 
> Introduced LayoutTest flakiness on WK1.
> 
> Committed r224511: <https://trac.webkit.org/changeset/224511>
Fixed.
+    : m_clipped(false)

[WebKit Commit Bot]

Comment on attachment 326183 [details]
Patch

Clearing flags on attachment: 326183

Committed r224529: <https://trac.webkit.org/changeset/224529>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.