| Summary: | [LayoutState cleanup] Move m_layoutState from RenderView to LayoutContext | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, buildbot, commit-queue, koivisto, ryanhaddad, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2017-11-03 22:02:57 PDT
Created attachment 326058 [details]
Patch
Attachment 326058 [details] did not pass style-queue:
ERROR: Source/WebCore/style/RenderTreeUpdaterFirstLetter.cpp:223: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5]
ERROR: Source/WebCore/style/RenderTreeUpdaterListItem.cpp:74: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5]
Total errors found: 2 in 34 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 326058 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326058&action=review > Source/WebCore/rendering/RenderBlockFlow.cpp:741 > + bool paginated = view().frameView().layoutContext().layoutState()->isPaginated(); If this wasn't temporary we'd want layoutState() helper. Comment on attachment 326058 [details] Patch Clearing flags on attachment: 326058 Committed r224494: <https://trac.webkit.org/changeset/224494> All reviewed patches have been landed. Closing bug. This change appears to have caused flakiness with LayoutTests in the fast/repaint directory on WK1. Example of failures: https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r224495%20(4699)/results.html (In reply to Ryan Haddad from comment #7) > This change appears to have caused flakiness with LayoutTests in the > fast/repaint directory on WK1. Example of failures: > https://build.webkit.org/results/ > Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r224495%20(4699)/results.html I can repro locally with a build of r224494 with the following command: run-webkit-tests -1 fast/repaint/transform-table-layout.html fast/repaint/focus-ring-repaint.html --iter 200 --no-retry-failure Reverted r224494 for reason: Introduced LayoutTest flakiness on WK1. Committed r224511: <https://trac.webkit.org/changeset/224511> Created attachment 326183 [details]
Patch
Attachment 326183 [details] did not pass style-queue:
ERROR: Source/WebCore/style/RenderTreeUpdaterFirstLetter.cpp:223: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5]
ERROR: Source/WebCore/style/RenderTreeUpdaterListItem.cpp:74: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5]
Total errors found: 2 in 34 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to Ryan Haddad from comment #9) > Reverted r224494 for reason: > > Introduced LayoutTest flakiness on WK1. > > Committed r224511: <https://trac.webkit.org/changeset/224511> Fixed. + : m_clipped(false) Comment on attachment 326183 [details] Patch Clearing flags on attachment: 326183 Committed r224529: <https://trac.webkit.org/changeset/224529> All reviewed patches have been landed. Closing bug. |