| Summary: | [JSC][JIT] Clean up SlowPathCall stubs | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | buildbot, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2017-11-03 10:46:34 PDT
Created attachment 325916 [details]
Patch
Comment on attachment 325916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325916&action=review nice cleanup. r=me > Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:283 > +SLOW_PATH_DECL(slow_path_check_tdz) > +{ > + BEGIN(); > + THROW(createTDZError(exec)); > +} Not a fan of this name, this used to be called throw_tdz_error or whatever, which I think is more intuitive. Comment on attachment 325916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325916&action=review > Source/JavaScriptCore/ChangeLog:8 > + We have bunch of duplicate functions that just calls a slow path function. calls => call Comment on attachment 325916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325916&action=review Thanks >> Source/JavaScriptCore/ChangeLog:8 >> + We have bunch of duplicate functions that just calls a slow path function. > > calls => call Fixed! >> Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:283 >> +} > > Not a fan of this name, this used to be called throw_tdz_error or whatever, which I think is more intuitive. Currently, we rely on this name because we mechanically call slow_path function that has the same name to the opcode :( Committed r224626: <https://trac.webkit.org/changeset/224626> |