Bug 179219

Summary: [WinCairo] LayoutTests doesn't read TextExpectations files correctly
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: Tools / TestsAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, basuke, bfulgham, buildbot, commit-queue, glenn, lforschler, pvollan, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 179216    
Attachments:
Description Flags
patch
none
fix webkit-testpy failures none

Basuke Suzuki
Reported 2017-11-02 17:29:26 PDT
It runs entire files on Windows if it runs from CommandPrompt or PowerShell.
Attachments
patch (3.75 KB, patch)
2017-11-09 14:49 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
fix webkit-testpy failures (4.11 KB, patch)
2017-11-09 16:34 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2017-11-02 17:31:14 PDT
It seems test_expectations.py: TestExpectationsParser::_collect_matching_tests() just compare strings with no care about path delimiter.
Basuke Suzuki
Comment 2 2017-11-09 14:40:01 PST
TestConfigulation are created incorrectly. That's the reason each tests matching to skip expectations are treated as 'PASS'.
Basuke Suzuki
Comment 3 2017-11-09 14:49:31 PST
Created attachment 326491 [details] patch
Basuke Suzuki
Comment 4 2017-11-09 14:50:43 PST
Comment on attachment 326491 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=326491&action=review > Tools/Scripts/webkitpy/port/apple.py:-92 > - allowed_port_names = self.VERSION_FALLBACK_ORDER + [self.operating_system() + "-future"] This line is not used. > Tools/Scripts/webkitpy/port/apple.py:125 > + for port_name in self._allowed_port_names(): extract this list generation for easy refactoring.
Basuke Suzuki
Comment 5 2017-11-09 16:34:02 PST
Created attachment 326508 [details] fix webkit-testpy failures
WebKit Commit Bot
Comment 6 2017-11-10 16:20:34 PST
Comment on attachment 326508 [details] fix webkit-testpy failures Clearing flags on attachment: 326508 Committed r224714: <https://trac.webkit.org/changeset/224714>
WebKit Commit Bot
Comment 7 2017-11-10 16:20:36 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-11-15 09:41:33 PST
<rdar://problem/35562239>
Note You need to log in before you can comment on or make changes to this bug.