Bug 179219

Summary: [WinCairo] LayoutTests doesn't read TextExpectations files correctly
Product: WebKit Reporter: Basuke Suzuki <Basuke.Suzuki>
Component: Tools / TestsAssignee: Basuke Suzuki <Basuke.Suzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, Basuke.Suzuki, bfulgham, buildbot, commit-queue, glenn, lforschler, pvollan, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 179216    
Attachments:
Description Flags
patch
none
fix webkit-testpy failures none

Description Basuke Suzuki 2017-11-02 17:29:26 PDT
It runs entire files on Windows if it runs from CommandPrompt or PowerShell.
Comment 1 Basuke Suzuki 2017-11-02 17:31:14 PDT
It seems test_expectations.py:
TestExpectationsParser::_collect_matching_tests() just compare strings with no care about path delimiter.
Comment 2 Basuke Suzuki 2017-11-09 14:40:01 PST
TestConfigulation are created incorrectly. That's the reason each tests matching to skip expectations are treated as 'PASS'.
Comment 3 Basuke Suzuki 2017-11-09 14:49:31 PST
Created attachment 326491 [details]
patch
Comment 4 Basuke Suzuki 2017-11-09 14:50:43 PST
Comment on attachment 326491 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326491&action=review

> Tools/Scripts/webkitpy/port/apple.py:-92
> -        allowed_port_names = self.VERSION_FALLBACK_ORDER + [self.operating_system() + "-future"]

This line is not used.

> Tools/Scripts/webkitpy/port/apple.py:125
> +        for port_name in self._allowed_port_names():

extract this list generation for easy refactoring.
Comment 5 Basuke Suzuki 2017-11-09 16:34:02 PST
Created attachment 326508 [details]
fix webkit-testpy  failures
Comment 6 WebKit Commit Bot 2017-11-10 16:20:34 PST
Comment on attachment 326508 [details]
fix webkit-testpy  failures

Clearing flags on attachment: 326508

Committed r224714: <https://trac.webkit.org/changeset/224714>
Comment 7 WebKit Commit Bot 2017-11-10 16:20:36 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-11-15 09:41:33 PST
<rdar://problem/35562239>