Bug 179204

Summary: Reduce duplication in the toplevel Makefile
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, commit-queue, mitz, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2017-11-02 15:31:32 PDT
Reduce duplication in the toplevel Makefile
Attachments
Patch (1.41 KB, patch)
2017-11-02 15:31 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (1.49 KB, patch)
2017-11-02 16:31 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (1.81 KB, patch)
2017-11-02 19:18 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2017-11-02 15:31:51 PDT
Created attachment 325780 [details] Patch
WebKit Commit Bot
Comment 2 2017-11-02 16:00:20 PDT
Comment on attachment 325780 [details] Patch Clearing flags on attachment: 325780 Committed r224361: <https://trac.webkit.org/changeset/224361>
WebKit Commit Bot
Comment 3 2017-11-02 16:00:21 PDT
All reviewed patches have been landed. Closing bug.
mitz
Comment 4 2017-11-02 16:14:01 PDT
Comment on attachment 325780 [details] Patch Does this change the build order such that libwebrtc builds after WebCore?
Tim Horton
Comment 5 2017-11-02 16:25:36 PDT
A good point! I will fix it.
Tim Horton
Comment 6 2017-11-02 16:31:11 PDT
Reopening to attach new patch.
Tim Horton
Comment 7 2017-11-02 16:31:12 PDT
Created attachment 325793 [details] Patch
Tim Horton
Comment 8 2017-11-02 17:01:53 PDT
Follow up landed in https://trac.webkit.org/changeset/224363/webkit
Tim Horton
Comment 9 2017-11-02 19:18:56 PDT
Reopening to attach new patch.
Tim Horton
Comment 10 2017-11-02 19:18:57 PDT
Created attachment 325820 [details] Patch
Tim Horton
Comment 11 2017-11-02 19:19:23 PDT
Comment on attachment 325820 [details] Patch Not my greatest success.
WebKit Commit Bot
Comment 12 2017-11-02 19:51:02 PDT
Comment on attachment 325820 [details] Patch Clearing flags on attachment: 325820 Committed r224372: <https://trac.webkit.org/changeset/224372>
WebKit Commit Bot
Comment 13 2017-11-02 19:51:04 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 14 2017-11-15 12:30:45 PST
<rdar://problem/35567681>
Note You need to log in before you can comment on or make changes to this bug.