Bug 179204 - Reduce duplication in the toplevel Makefile
Summary: Reduce duplication in the toplevel Makefile
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-02 15:31 PDT by Tim Horton
Modified: 2017-11-15 12:30 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.41 KB, patch)
2017-11-02 15:31 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (1.49 KB, patch)
2017-11-02 16:31 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (1.81 KB, patch)
2017-11-02 19:18 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-11-02 15:31:32 PDT 
Reduce duplication in the toplevel Makefile
Comment 1 Tim Horton 2017-11-02 15:31:51 PDT 
Created attachment 325780 [details]
Patch
Comment 2 WebKit Commit Bot 2017-11-02 16:00:20 PDT 
Comment on attachment 325780 [details]
Patch

Clearing flags on attachment: 325780

Committed r224361: <https://trac.webkit.org/changeset/224361>
Comment 3 WebKit Commit Bot 2017-11-02 16:00:21 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 mitz 2017-11-02 16:14:01 PDT 
Comment on attachment 325780 [details]
Patch

Does this change the build order such that libwebrtc builds after WebCore?
Comment 5 Tim Horton 2017-11-02 16:25:36 PDT 
A good point! I will fix it.
Comment 6 Tim Horton 2017-11-02 16:31:11 PDT 
Reopening to attach new patch.
Comment 7 Tim Horton 2017-11-02 16:31:12 PDT 
Created attachment 325793 [details]
Patch
Comment 8 Tim Horton 2017-11-02 17:01:53 PDT 
Follow up landed in https://trac.webkit.org/changeset/224363/webkit
Comment 9 Tim Horton 2017-11-02 19:18:56 PDT 
Reopening to attach new patch.
Comment 10 Tim Horton 2017-11-02 19:18:57 PDT 
Created attachment 325820 [details]
Patch
Comment 11 Tim Horton 2017-11-02 19:19:23 PDT 
Comment on attachment 325820 [details]
Patch

Not my greatest success.
Comment 12 WebKit Commit Bot 2017-11-02 19:51:02 PDT 
Comment on attachment 325820 [details]
Patch

Clearing flags on attachment: 325820

Committed r224372: <https://trac.webkit.org/changeset/224372>
Comment 13 WebKit Commit Bot 2017-11-02 19:51:04 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 14 Radar WebKit Bug Importer 2017-11-15 12:30:45 PST 
<rdar://problem/35567681>